Skip to content

cmake: keep private include dirs out of dependencies - #16048

Draft
tomatotomata wants to merge 1 commit into
mesonbuild:masterfrom
tomatotomata:codex/cmake-private-include-13818
Draft

cmake: keep private include dirs out of dependencies#16048
tomatotomata wants to merge 1 commit into
mesonbuild:masterfrom
tomatotomata:codex/cmake-private-include-13818

Conversation

@tomatotomata

Copy link
Copy Markdown

Summary

  • keep CMake target-private include directories on the converted target only
  • expose only INTERFACE include directories through the generated Meson dependency
  • preserve public and private include paths for the target itself

Fixes #13818

Validation

  • python -m compileall -q mesonbuild/cmake
  • git diff --check
  • python -m pytest -q unittests --disable-warnings --maxfail=1 (blocked by the environment: pytest-recording and pytest-vcr are both installed)
  • run_tests.py was blocked because Ninja is not installed in this environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meson does not respect target_include_directories(PRIVATE) in CMake subprojects

1 participant