Add CLI implementation to PkgConfigCLI - #16042
Conversation
|
Are you sure that the change there is intentional, and not another regression? Why is this different to pkgconf/pkgconf#575? I appreciate that the version comparison was wrong here but I'd still like to know if this was a change pkgconf actually wants to make or not. Please also tag #16019. |
|
I would like to resolve pkgconf/pkgconf#575 (comment) before continuing to move forward with this PR. |
|
The pkgconf maintainer said that this is considered a regression in 3.0.4. |
Note that this was fixed with pkgconf 3.0.5. |
|
I pushed what I believe to be a working commit now that 3.0.5 has the fix we need. I think I have correctly fixed the version check to test what correct value should be. |
By knowing the implementation of pkg-config, we can make better decisions when special-casing code. As you can see in the following test change, that version comparison was really only meant for the FreeDesktop implementation. Signed-off-by: Tristan Partin <tristan@partin.io>
4 participants
By knowing the implementation of pkg-config, we can make better decisions when special-casing code. As you can see in the following test change, that version comparison was really only meant for the FreeDesktop implementation.