platform: implement path_has_root() on OS/2#15977
Open
komh wants to merge 1 commit into
Open
Conversation
Contributor
|
Can you split the |
Contributor
|
Fixing the linters requires moving the non-Windows/os2 definition as the |
komh
force-pushed
the
pr-destdir
branch
6 times, most recently
from
89e9c2e to
b214f74
Compare
OS/2 has the same problem as Windows. '/path/to/f' is not treated as an absolute path. Especially, DESTDIR is always appended to the build dir.
Contributor
Author
|
|
Contributor
|
Still quite ugly. Why not just an if/else specific to path_has_root? |
Contributor
Author
|
I think, this patch already has if-else block specific to path_has_root. Do you mean add if-else without moving path_has_root? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OS/2 has the same problem as Windows. '/path/to/f' is not treated as an absolute path.
Especially, DESTDIR is always appended to the build dir.