GnuCompiler.has_arguments: detect "not supported for this target" warnings#15876
Open
lzwind wants to merge 1 commit into
Open
GnuCompiler.has_arguments: detect "not supported for this target" warnings#15876lzwind wants to merge 1 commit into
lzwind wants to merge 1 commit into
Conversation
…nings GCC may exit with code 0 while emitting a warning that an option is "not supported for this target" (e.g., HPPA with -fstack-protector). Add this pattern to the stderr inspection in has_arguments() so such flags are correctly reported as unsupported. Fixes: mesonbuild#5355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"not supported for this target"(e.g., HPPA with-fstack-protector). Previously,has_arguments()only checked for cross-language warnings ("is valid for C/ObjC"/"is valid for C++/ObjC++")."not supported for this target"pattern to the stderr inspection inhas_arguments()so such flags are correctly reported as unsupported.Partially fixes: #5355
Test plan
compiler.get_supported_arguments()correctly returnsfalsefor target-unsupported flags (e.g.,-fstack-protectoron HPPA)