fix(ui): Fix for rssi/snr #973
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a fix for a bug introduced in PR #963. If the RSSI/SNR infomation wasnt available the UI was displaying a 0 instead of the content. This PR fixes that bug that was introduced.
Related Issues
Fixes bug from PR#963
Changes Made
Changed message.hops && to message.hops != null so that 0 won't render as text
Improved readability: Extracted the complex conditional logic into a messageMetadata variable using clear if statements
The JSX now just uses {messageMetadata} instead of nested && and || operators
The logic is now clear and easy to follow:
Testing Done
Manual
Screenshots (if applicable)
BEFORE

AFTER:
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)