AsyncUDP: keep track of the last sent packet and skip it while LOOPing #59
+68
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested it and it works, it can't have the 2+ packets race bug. |
Jorropo
force-pushed
the
skip-looped-mudp
branch
2 times, most recently
from
e31ab9f to
628b4fe
Compare
This means we don't invoke the receive handler for packets we send.
Jorropo
force-pushed
the
skip-looped-mudp
branch
2 times, most recently
from
21d8462 to
46234a6
Compare
Jorropo
force-pushed
the
skip-looped-mudp
branch
from
46234a6 to
6ea9cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we don't invoke the receive handler for packets we send.
Closes meshtastic/firmware#7661 (the only needed change in
meshtastic/firmwareis to bump the dependencies to use this commit)