-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Cleanup of csv files produced by the range-test module #7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to delete previously stored range test CSV files from the filesystem. It extends the RangeTestModuleRadio
class with a new removeFile()
method that can clean up range test data, addressing issue #7291.
- Adds a new public method
removeFile()
to delete range test CSV files - Implements filesystem cleanup with proper error handling and logging
- Includes ESP32 architecture-specific implementation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/modules/RangeTestModule.h | Adds declaration for the new removeFile() method |
src/modules/RangeTestModule.cpp | Implements the removeFile() method with filesystem operations and error handling |
I've just met with a friend and tested this on each of our Heltec v3 devices. Steps taken to test:
// service->sendToMesh(p);
this->removeFile();
|
Resolves #7291
Extends the functionality of
RangeTestModuleRadio
to include the ability to delete previously stored range test results.I don't have a second node to use the range test feature with, although I've compiled and flashed my changes from source and everything still works as it should.This has been tested on two heltec v3 devices 👍
To see this feature request completed would require some work on the user interfaces, I.e. some kind of new button which invokes
RangeTestModuleRadio::removeFile()
.This is my first contribution here so If any potential changes must be made let me know, I'm more than happy to oblige 🔧
Attestations