Skip to content

Conversation

@Thund3rHawk
Copy link

@Thund3rHawk Thund3rHawk commented Nov 26, 2025

Description

This PR fixes #2178

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Nov 26, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit fd55150
🔍 Latest deploy log https://app.netlify.com/projects/mesheryio-preview/deploys/6927efa8a3aa5100081516ac
😎 Deploy Preview https://deploy-preview-2440--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Thund3rHawk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive 'Newcomers' guide page aimed at streamlining the onboarding process for new contributors. It integrates various resources, including a step-by-step contribution guide, a curated list of tutorials, and direct links to community engagement platforms. The goal is to provide a welcoming and informative entry point for individuals looking to get involved with the project, enhancing the overall contributor experience.

Highlights

  • Newcomers Guide Page: A dedicated 'Newcomers' guide page has been added to the website, providing a centralized resource for new contributors.
  • Navigation Integration: A new 'Newcomers' link has been added to the main navigation menu, making the guide easily accessible.
  • Contribution Workflow: A detailed 'How to Contribute' section is included, outlining steps from finding issues to working on them and engaging with the community.
  • Tutorials Section: A new section featuring a table of tutorials has been introduced, complete with dates, topics, resources (slides, recordings), and presenters, to help new contributors get started.
  • Community Call-to-Action: A 'Join the community!' section with a call-to-action button to join the Slack workspace has been added to encourage engagement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new dedicated page for newcomers, which is a great initiative. It includes a contributor's journey map, a guide on how to contribute, a list of tutorials, and a call to action to join the community. The changes are well-structured, but there are several areas for improvement regarding code quality and maintainability.

Key feedback points:

  • CSS Organization: Several new HTML files contain large blocks of inline CSS. It would be better to extract these styles into separate SCSS files under the _sass directory for better organization, maintainability, and reusability, following the pattern already used for _sass/tutorials-table.scss.
  • Code Quality: There are some issues like placeholder links (href="#"), invalid HTML attributes (target=""), and incorrect SCSS selectors that need to be addressed.
  • Best Practices: The use of !important in CSS should be avoided as it can lead to maintenance issues. Also, several new files are missing a final newline character, which is a common convention.
  • Sass Syntax: There's a syntax error in css/screen.scss that will break the SCSS compilation.

@Namanv0509
Copy link
Member

@Thund3rHawk please look over the suggestions first and resolve them if in high priority.

@Thund3rHawk
Copy link
Author

Resolved high and medium priority bugs as per code review recommendations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Creating a dedicated Newcomer's Guide

2 participants