Skip to content

Conversation

@omkarht
Copy link
Contributor

@omkarht omkarht commented Nov 7, 2025

📑 Summary

This PR reverts the hexagon and roundedRect shape implementations back to their original code.
These changes remove the dependencies on the simplified helper functions that were previously introduced.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: 43b7db9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 43b7db9
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/690dae8fb6d63100081b1c6d
😎 Deploy Preview https://deploy-preview-7139--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 7, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7139

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7139

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7139

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7139

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7139

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7139

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7139

commit: 43b7db9

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 2.63158% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.55%. Comparing base (f45ea0c) to head (43b7db9).
⚠️ Report is 46 commits behind head on develop.

Files with missing lines Patch % Lines
...endering-util/rendering-elements/shapes/hexagon.ts 0.00% 29 Missing ⚠️
...ring-util/rendering-elements/shapes/roundedRect.ts 11.11% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7139   +/-   ##
=======================================
  Coverage     3.55%   3.55%           
=======================================
  Files          474     474           
  Lines        47507   47419   -88     
  Branches       730     730           
=======================================
+ Hits          1687    1688    +1     
+ Misses       45820   45731   -89     
Flag Coverage Δ
unit 3.55% <2.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ring-util/rendering-elements/shapes/roundedRect.ts 7.69% <11.11%> (+7.69%) ⬆️
...endering-util/rendering-elements/shapes/hexagon.ts 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci
Copy link

argos-ci bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 230 changed Nov 7, 2025, 8:53 AM

@omkarht omkarht marked this pull request as ready for review November 7, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sponsored by MermaidChart Type: Other Not an enhancement or a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants