PML-261: Add post-selection to MerLin utils.#185
Draft
anthonyrtw wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow Perceval-style post-selection rules to a batch of probability distributions indexed by a number of keys. May be immediately applied to the output of a
SLOSComputeGraph. Additionally a unit test has been added for this feature undertests/utils/test_postselection.py.Type of change
Proposed changes
Add new function in
utils/post_selection.pycalledpost_select_probs. It takes a batch of probability vectors and a post-selection rules.Additionally, one can decide whether they want the output keys to be written in the post-selected basis or the original basis using the
same_keysargument. Default:TrueThe code works by masking the each probability value based on whether its key obeys the post-selection rule. The probability vectors are then normalized.
How to test
Performance considerations
PostSelectis handled byexqalibur(written in C++). It stands to reason that if exqalibur is updated to allow evaluation over a batch of keys (list of tuples/lists), the performance would be increased.