feat: Add ja-JP (Japanese) locale with tests#27
Merged
patrickdevivo merged 1 commit intomainfrom Sep 30, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds Japanese (ja-JP) locale support to the timediff library with comprehensive test coverage. The implementation follows the same time range patterns as existing locales and provides culturally appropriate Japanese time expressions.
- Added Japanese locale formatter with proper time expressions (数秒前, 分前, 時間前, etc.)
- Implemented comprehensive test coverage with 38 test cases covering all time ranges
- Registered locale under both "ja" and "ja-JP" identifiers for flexibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| locale/ja-JP.go | Implements Japanese time difference formatters with appropriate translations |
| timediff_ja_JP_test.go | Provides comprehensive test coverage for Japanese locale functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Added Japanese locale support with comprehensive test coverage. Translations follow the same time range patterns as other locales. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
patrickdevivo
force-pushed
the
add-ja-jp-locale
branch
from
ae0e5a3 to
ba1771e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Japanese locale support with comprehensive test coverage. Translations follow the same time range patterns as other locales.
🤖 Generated with Claude Code