Skip to content

Conversation

@Bloxigus
Copy link
Collaborator

me no likey code pls reivew so better

ive got some todos but havent a clue how to do either of them so pls 🥺

probably doesnt work well with multiversion i havent tested it

@Bloxigus Bloxigus marked this pull request as ready for review December 28, 2025 16:38
@j10a1n15
Copy link
Member

surely do you wanbt to write docs for this

import me.owdding.catharsis.features.entity.models.CustomEntityModel;
import org.jetbrains.annotations.Nullable;

public interface EntityRenderStateHook {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabric has a generic render state injection so maybe that can be used instead of this? idk if its in 1.21.8 though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not :c

resourceManager: ResourceManager,
profiler: ProfilerFiller,
): List<CustomEntityDefinition> {
return converter.listMatchingResources(resourceManager)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be the same as gui definitions with the logger and the extensions

@meowora meowora deleted the branch meowdding:development December 29, 2025 21:21
@meowora meowora closed this Dec 29, 2025
@meowora meowora reopened this Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants