add meow-keypad-capital-letter-add-ctrl #723
Open
ab9986 wants to merge 2 commits intomeow-edit:masterfrom
Open
add meow-keypad-capital-letter-add-ctrl #723ab9986 wants to merge 2 commits intomeow-edit:masterfrom
ab9986 wants to merge 2 commits intomeow-edit:masterfrom
Conversation
letter, add ctrol in front of it and change the capital letter to lowercase.input uppercase letter add ctrol before. For example use `SPC x F' to execute `C-x C-f' .
ventruvian
reviewed
Nov 21, 2025
| (map-keymap | ||
| (lambda (key def) | ||
| (when (member 'control (event-modifiers key)) | ||
| (when (if meow-keypad-capital-letter-add-ctrl t (member 'control (event-modifiers key))) |
There was a problem hiding this comment.
(or meow-keypad-capital-letter-add-ctrl
(member 'control (event-modifiers key))
ventruvian
reviewed
Nov 21, 2025
| (map-keymap | ||
| (lambda (key def) | ||
| (when (and (not (member 'control (event-modifiers key))) | ||
| (when (and (if meow-keypad-capital-letter-add-ctrl t (not (member 'control (event-modifiers key)))) |
There was a problem hiding this comment.
(or meow-keypad-capital-letter-add-ctrl
(not (member 'control (event-modifiers key)))
ventruvian
reviewed
Nov 21, 2025
| (map-keymap | ||
| (lambda (key def) | ||
| (unless (member 'control (event-modifiers key)) | ||
| (unless (if meow-keypad-capital-letter-add-ctrl nil (member 'control (event-modifiers key))) |
There was a problem hiding this comment.
(if (or meow-keypad-capital-letter-add-ctrl
(not (member 'control (event-modifiers key))))
...)
|
Wouldn't the feature you propose reduce If anything I think I didn't know github shows code-comments here so prominently. I didn't actually "review" this, nor am I a contributor, just wanted to make you aware of some trivial simplifications |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whether to enter a capital letter, add ctrol in front of it and change
the capital letter to lowercase.input uppercase letter add ctrol
before.
For example use
SPC x F' to executeC-x C-f' .