Skip to content

fix(deps): align aegis js-yaml manifest pin with the override floor - #1383

Merged
chapati23 merged 1 commit into
mainfrom
fix/aegis-js-yaml-pin
Jul 21, 2026
Merged

fix(deps): align aegis js-yaml manifest pin with the override floor#1383
chapati23 merged 1 commit into
mainfrom
fix/aegis-js-yaml-pin

Conversation

@chapati23

@chapati23 chapati23 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The Problem

  • aegis/package.json still declares js-yaml: 4.2.0 exact while the workspace override floor forces 4.3.0 — the pin is stale, and if the override is ever pruned, a fresh install silently downgrades aegis back to the vulnerable version.

The Solution

🤖 Generated with Claude Code

https://claude.ai/code/session_01CiUreX7DKuRKiHQT6HkY4z


Note

Low Risk
Single dependency version pin bump with no application or lockfile changes; security-relevant only in that it documents the patched floor.

Overview
Updates the aegis direct dependency on js-yaml from 4.2.0 to 4.3.0 so the manifest matches the workspace override minimum and what installs already resolve.

This is manifest-only alignment (no lockfile or runtime code changes); it avoids a future install path where a removed override could pull 4.2.0 back in for aegis.

Reviewed by Cursor Bugbot for commit a298ef4. Configure here.

The exact 4.2.0 pin disagreed with the resolved 4.3.0 — a future override
removal would silently downgrade back to the vulnerable version.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CiUreX7DKuRKiHQT6HkY4z
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
monitoring-dashboard Ignored Ignored Preview Jul 21, 2026 12:33pm

Request Review

@claude

claude Bot commented Jul 21, 2026

Copy link
Copy Markdown

Claude finished @chapati23's task in 50s —— View job


Review complete

  • Gather context (PR diff, package.json, pnpm overrides)
  • Review the change for correctness
  • Check lockfile / override alignment
  • Post final review

Verdict: LGTM

Findings

  1. [P3] None — the change is correct and minimal. aegis/package.json bumps js-yaml from 4.2.04.3.0, matching the workspace override floor "js-yaml@>=4.0.0 <4.3.0": 4.3.0 in pnpm-workspace.yaml:83. Confirmed pnpm-lock.yaml already records specifier: 4.3.0 / version: 4.3.0 for the aegis package (lines 140–142), so leaving the lockfile untouched is correct — no pnpm install was needed.

Verification performed

  • Diffed aegis/package.json against origin/main — only the single-line pin bump, as described.
  • Confirmed the override that motivates this fix: pnpm-workspace.yaml:83 (js-yaml@>=4.0.0 <4.3.04.3.0), part of the advisory override floors refreshed in fix(deps): refresh advisory override floors #1381.
  • Confirmed pnpm-lock.yaml's aegis dependency block already resolves js-yaml to 4.3.0, so the manifest was previously silently relying on the override — this PR removes that latent drift risk (manifest now matches what's actually installed, so pruning the override later won't cause a silent downgrade).
  • No other files changed; scope matches the stated PR description exactly.

Straightforward, correctly-scoped supply-chain hygiene fix. Nothing to flag.

@chapati23
chapati23 merged commit d4b8dc6 into main Jul 21, 2026
29 of 31 checks passed
@chapati23
chapati23 deleted the fix/aegis-js-yaml-pin branch July 21, 2026 17:08
chapati23 added a commit that referenced this pull request Jul 21, 2026
* origin/main:
  fix(deps): align aegis js-yaml manifest pin with the override floor (#1383)
  feat(ci): Sentry autofix PRs (ADR 0036 Phase 2b) (#1374)

# Conflicts:
#	docs/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant