Skip to content

Conversation

@Noarkhh
Copy link
Contributor

@Noarkhh Noarkhh commented Oct 15, 2025

  • include membrane_tutorials in the docs
  • put separate tutorials and concepts into sections

ToDo:

  • H264 tutorial in Broadcasting is outdated
  • PNGs with transparent background dont look good on dark theme (that's also the case on the website)

@Noarkhh Noarkhh requested a review from mat-hek as a code owner October 15, 2025 09:50
@Noarkhh Noarkhh self-assigned this Oct 15, 2025
@Noarkhh Noarkhh added this to Smackore Oct 15, 2025
@Noarkhh Noarkhh moved this to In Progress in Smackore Oct 15, 2025
@Noarkhh Noarkhh added the no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md label Oct 15, 2025
@Noarkhh Noarkhh moved this from In Progress to In Review in Smackore Oct 22, 2025
Copy link
Member

@mat-hek mat-hek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating docs throws warnings

Comment on lines +166 to +176
"Get started with Membrane":
Path.wildcard("guides/membrane_tutorials/get_started_with_membrane/*.md"),
"Intro to pipelines": Path.wildcard("guides/membrane_tutorials/basic_pipeline/*.md"),
"Intro to pipelines - advanced concepts":
Path.wildcard("guides/membrane_tutorials/basic_pipeline_extension/*.md"),
"Creating plugins": Path.wildcard("guides/membrane_tutorials/create_new_plugin/*.md"),
"Useful concepts": Path.wildcard("guides/useful_concepts/*.md"),
H264: Path.wildcard("guides/membrane_tutorials/h264/*.md"),
Broadcasting: Path.wildcard("guides/membrane_tutorials/broadcasting/*.md"),
Glossary: Path.wildcard("guides/membrane_tutorials/glossary/*.md"),
Upgrading: Path.wildcard("guides/upgrading/*.md")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we generate this automatically?
  • I thought you merged the pipelines tutorials into one?

Copy link
Contributor Author

@Noarkhh Noarkhh Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We can but I'm not sure if we should, this way it's easier to modify the titles and you have more fine grained control
  • I did, I removed this group in the next PR, but if a group has no contets it's not being displayed, so dont worry, it's not visible. About the warnings, they are thrown because membrane_tutorial fixing them isn't merged yet, and the submodule in guides points to the master branch.

@Noarkhh Noarkhh requested a review from mat-hek October 29, 2025 13:02
@Noarkhh Noarkhh merged commit f3c8fa4 into master Oct 29, 2025
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Smackore Oct 29, 2025
@Noarkhh Noarkhh deleted the restructure-docs branch October 29, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants