Fix bugs and bump version to 0.1.2 #9
Conversation
FelonEkonom
requested review from
Copilot and
varsill
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bugs and bumps the version from 0.1.1 to 0.1.2. The changes include error handling improvements, file existence checking, and debug code additions.
- Simplified error handling in CMAF demuxing engine to use a catch-all pattern
- Added file existence waiting mechanism to prevent race conditions when reading files
- Updated version references across the codebase
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| mix.exs | Version bump from 0.1.1 to 0.1.2 |
| lib/ex_hls/demuxing_engine/cmaf.ex | Simplified error handling with catch-all pattern |
| lib/ex_hls/client/utils.ex | Added file existence waiting mechanism |
| lib/ex_hls/client/live/reader.ex | Added commented debug code |
| README.md | Updated dependency version reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| defp await_until_file_exists!(file_path) do | ||
| cond do | ||
| File.exists?(file_path) -> :ok | ||
| Process.sleep(20) && File.exists?(file_path) -> :ok | ||
| Process.sleep(60) && File.exists?(file_path) -> :ok | ||
| Process.sleep(180) && File.exists?(file_path) -> :ok | ||
| true -> raise "File #{file_path} does not exist" | ||
| end | ||
| end |
There was a problem hiding this comment.
The hardcoded sleep intervals (20, 60, 180 ms) are magic numbers that make the code difficult to maintain and understand. Consider extracting these values as module attributes or configuration parameters with descriptive names.
lib/ex_hls/client/live/reader.ex
Outdated
| # |> IO.inspect(label: "SPLITTED TRACKS DATA") | ||
|
|
There was a problem hiding this comment.
Commented debug code should be removed before merging to production. This appears to be leftover debugging code that adds no value to the codebase.
| # |> IO.inspect(label: "SPLITTED TRACKS DATA") |
lib/ex_hls/client/live/reader.ex
Outdated
| {:ok, track_id} | ||
| end | ||
|
|
||
| # |> IO.inspect(label: "TRACK ID TO READ") |
There was a problem hiding this comment.
Commented debug code should be removed before merging to production. This appears to be leftover debugging code that adds no value to the codebase.
| # |> IO.inspect(label: "TRACK ID TO READ") |
No description provided.