Adjust to mpeg_ts v3 API #17
Conversation
| case Map.get(demuxing_engine.packets_map, track_id) do | ||
| [packet | rest] -> | ||
| demuxing_engine = put_in(demuxing_engine.packets_map[track_id], rest) | ||
| {[packet], demuxing_engine} | ||
|
|
||
| _other -> | ||
| {[], demuxing_engine} | ||
| end |
There was a problem hiding this comment.
| case Map.get(demuxing_engine.packets_map, track_id) do | |
| [packet | rest] -> | |
| demuxing_engine = put_in(demuxing_engine.packets_map[track_id], rest) | |
| {[packet], demuxing_engine} | |
| _other -> | |
| {[], demuxing_engine} | |
| end | |
| get_and_update_in(demuxing_engine.packets_map[track_id], fn | |
| [packet | rest] -> {[packet], rest} | |
| other -> {[], other} | |
| end |
I'd also move this function below pop_chunk
There was a problem hiding this comment.
I don't think we can use get_and_update_in here, as if we were to call take_packets/2 for a track_id which is not yet in packets_map, it would add an empty entry under this track_id key.
(it might happen when track_id is resolved based on PMT, but no PES packet with given track_id has yet arrived)
|
|
||
| packets_map = | ||
| Enum.reduce(new_packets, demuxing_engine.packets_map, fn new_packet, packets_map -> | ||
| Map.update(packets_map, new_packet.pid, [new_packet], &(&1 ++ [new_packet])) |
| {maybe_tden_tag, demuxing_engine} = maybe_read_tden_tag(demuxing_engine, packet.payload.pts) | ||
| tden_tag = maybe_tden_tag || demuxing_engine.last_tden_tag |
There was a problem hiding this comment.
for me its unclear if maybe_read_tden_tag(demuxing_engine, packet.payload.pts)
- returns tden tag
- or sets it in
demuxing_engine.last_tden_tag - or both
because this function returns demuxing_engine as well as maybe_tden_tag. What about making it return only demuxing_engine?
| case Map.get(demuxing_engine.packets_map, track_id) do | ||
| [packet | rest] -> | ||
| demuxing_engine = put_in(demuxing_engine.packets_map[track_id], rest) | ||
| {[packet], demuxing_engine} | ||
|
|
||
| _other -> | ||
| {[], demuxing_engine} | ||
| end |
There was a problem hiding this comment.
if you want, you can use get_and_update_in - it will simplify this piece of code
There was a problem hiding this comment.
It would change the behaviour, as described here: #17 (comment)
| with {:ok, packets} <- Map.fetch(demuxing_engine.packets_map, track_id), | ||
| {{:value, packet}, rest} <- Qex.pop(packets) do | ||
| demuxing_engine = put_in(demuxing_engine.packets_map[track_id], rest) | ||
| {[packet], demuxing_engine} | ||
| else | ||
| _other -> {[], demuxing_engine} |
closes membraneframework/membrane_core#1017
Related PR in
kim_mpeg_ts: kim-company/kim_mpeg_ts#12