Remove nrepo from getAllKeys/getPubKeys output - #14
Open
melvincarvalho wants to merge 1 commit into
Open
Conversation
The nrepo encoding is never used. Removed from lib getAllKeys() and getPubKeys() (and JSDoc), the mirrored web core, the CLI test's expected-fields list, and the README feature list and example output. The web form already stopped displaying it; with this the JSON output drops it too. Breaking change to the output shape — warrants a version bump when next published. Stale lib/index.js.new and .saf backups left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13.
Removes the never-used
nrepofield from the source of truth, everywhere it's emitted:lib/index.js: dropped fromgetAllKeys()andgetPubKeys()output and JSDoc.web/assets/noskey-core.js: dropped from the mirrored functions, keeping the byte-for-byte web/CLI parity check green.test/cli.test.js: removed from the expected-fields list.README.md: removed the feature bullet and the example-output field.Verified:
npm test40/40;test/verify-core.jsall-pass (now 19 fields, matching both directions); CLI output contains nonrepo.Note: breaking change to the JSON output shape — worth a version bump on next npm publish. The stale
lib/index.js.new/.safbackup files and generateddocs/still mention nrepo but are untouched here (already stale on other fronts).Note
Low Risk
Removes an unused output field only; no changes to key derivation or security-sensitive logic, but downstream parsers expecting
nrepowill break until they adapt.Overview
Removes the unused
nrepobech32 field from noskey’s JSON output everywhere it was emitted, so CLI and browser stay aligned on the same shape.getAllKeys()andgetPubKeys()inlib/index.jsno longer compute or returnnrepo; JSDoc is updated. The browser mirror inweb/assets/noskey-core.jsmatches, and CLI tests dropnrepofrom the expected field list. README no longer lists or showsnrepoin the example JSON.This is a breaking change for consumers that relied on
nrepoin CLI/web JSON; a semver bump on publish is appropriate. Generateddocs/and backup files still mentionnrepobut are out of scope here.Reviewed by Cursor Bugbot for commit 86fabb7. Bugbot is set up for automated code reviews on this repo. Configure here.