fix: Remove TapCapabilities.ACTIVATE_VERSION in favor of PluginCapabilities.ACTIVATE_VERSION#3658
Merged
edgarrmondragon merged 3 commits intoMay 28, 2026
Conversation
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
…abilities.ACTIVATE_VERSION` Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the deprecated tap-level ACTIVATE_VERSION capability with the plugin-level capability, ensuring taps that support ACTIVATE_VERSION automatically receive the correct config defaults and aligning capability declarations with the shared plugin capabilities model. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3658 +/- ##
==========================================
- Coverage 93.88% 93.88% -0.01%
==========================================
Files 73 73
Lines 5954 5953 -1
Branches 731 731
==========================================
- Hits 5590 5589 -1
Misses 270 270
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Removing
TapCapabilities.ACTIVATE_VERSIONfrom the enum entirely may break existing taps that still reference it; consider keeping it as a deprecated alias that forwards toPluginCapabilities.ACTIVATE_VERSIONto ease migration. append_builtin_configis onPluginBaseand now injectsEMIT_ACTIVATE_VERSION_CONFIGfor any plugin withPluginCapabilities.ACTIVATE_VERSION; double-check whether this should be limited to taps only (e.g., via class/type check) to avoid unintentionally adding this config to targets or other plugin types.- Wherever
TapCapabilities.ACTIVATE_VERSIONmay be used in the codebase or templates (outside this diff), ensure they are consistently replaced withPluginCapabilities.ACTIVATE_VERSIONto avoid capability mismatches at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Removing `TapCapabilities.ACTIVATE_VERSION` from the enum entirely may break existing taps that still reference it; consider keeping it as a deprecated alias that forwards to `PluginCapabilities.ACTIVATE_VERSION` to ease migration.
- `append_builtin_config` is on `PluginBase` and now injects `EMIT_ACTIVATE_VERSION_CONFIG` for any plugin with `PluginCapabilities.ACTIVATE_VERSION`; double-check whether this should be limited to taps only (e.g., via class/type check) to avoid unintentionally adding this config to targets or other plugin types.
- Wherever `TapCapabilities.ACTIVATE_VERSION` may be used in the codebase or templates (outside this diff), ensure they are consistently replaced with `PluginCapabilities.ACTIVATE_VERSION` to avoid capability mismatches at runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSIA
Summary by Sourcery
Replace tap-level ACTIVATE_VERSION capability with the plugin-level capability and ensure corresponding config is injected when enabled.
Bug Fixes:
Enhancements:
Tests: