Skip to content

fix: Ensure stream name is include in log message when ACTIVATE_VERSION forces _sdc metadata columns#3650

Merged
edgarrmondragon merged 2 commits into
v0.54from
fix/activate-version-log-stream-name
May 27, 2026
Merged

fix: Ensure stream name is include in log message when ACTIVATE_VERSION forces _sdc metadata columns#3650
edgarrmondragon merged 2 commits into
v0.54from
fix/activate-version-log-stream-name

Conversation

@edgarrmondragon
Copy link
Copy Markdown
Collaborator

@edgarrmondragon edgarrmondragon commented May 27, 2026

SSIA

Summary by Sourcery

Bug Fixes:

  • Include the stream name in the log message emitted when ACTIVATE_VERSION forces _sdc metadata columns to be added.

…ON forces _sdc metadata columns

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
@edgarrmondragon edgarrmondragon self-assigned this May 27, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures the stream name is interpolated into the warning log emitted when ACTIVATE_VERSION forces _sdc metadata columns to be added while record metadata is disabled.

File-Level Changes

Change Details Files
Include the stream name in the ACTIVATE_VERSION forced-metadata warning log message.
  • Update the log message format string in _process_activate_version_message to accept a stream name parameter
  • Pass sink.stream_name as the argument for the '%s' placeholder in the warning log call so the stream is identified in logs
singer_sdk/target_base.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 27, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.81%. Comparing base (95e0b0b) to head (53a902d).

Additional details and impacted files
@@           Coverage Diff           @@
##            v0.54    #3650   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          73       73           
  Lines        5948     5948           
  Branches      729      729           
=======================================
  Hits         5580     5580           
  Misses        273      273           
  Partials       95       95           
Flag Coverage Δ
core 82.33% <ø> (ø)
end-to-end 75.21% <ø> (ø)
optional-components 42.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 27, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks


Comparing fix/activate-version-log-stream-name (53a902d) with main (ea0f833)1

Open in CodSpeed

Footnotes

  1. No successful run was found on v0.54 (95e0b0b) during the generation of this report, so main (ea0f833) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@edgarrmondragon edgarrmondragon merged commit 748f194 into v0.54 May 27, 2026
41 checks passed
@edgarrmondragon edgarrmondragon deleted the fix/activate-version-log-stream-name branch May 27, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant