fix(templates): Bump minimal required Tox to 4.53 and update configuration in templates#3641
Merged
Conversation
…ation in templates Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates tox-related configuration in all cookiecutter templates to require newer tox and tox-uv, simplifies the default env_list structure, bumps prek in GH workflow resources, and aligns the nox templates session with current tox CLI usage. Sequence diagram for updated nox templates session tox usagesequenceDiagram
participant nox_session as nox.Session
participant uvx
participant prek
participant tox
nox_session->>uvx: session.run("uvx", "prek", "run", "--all-files")
uvx->>prek: run
nox_session->>uvx: session.run("uvx", "--with=tox-uv", "tox", "list")
uvx->>tox: list
nox_session->>uvx: session.run("uvx", "--with=tox-uv", "tox", "-e=typing")
uvx->>tox: -e=typing
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The change from
{ product = [ { prefix = "3.", start = 10 }, ] }to{ prefix = "3.", start = 10 }in theenv_listalters the tox environment matrix structure; double-check that this simplified form still generates the intended set of Python environments with tox 4.53+.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change from `{ product = [ { prefix = "3.", start = 10 }, ] }` to `{ prefix = "3.", start = 10 }` in the `env_list` alters the tox environment matrix structure; double-check that this simplified form still generates the intended set of Python environments with tox 4.53+.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3641 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 73 73
Lines 5948 5948
Branches 729 729
=======================================
Hits 5580 5580
Misses 273 273
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update tooling versions and tox configuration used by project templates and CI resources.
Enhancements:
tox listcommand for environment discovery.Build: