Skip to content

fix(templates): Bump minimal required Tox to 4.53 and update configuration in templates#3641

Merged
edgarrmondragon merged 1 commit into
mainfrom
tox-up
May 25, 2026
Merged

fix(templates): Bump minimal required Tox to 4.53 and update configuration in templates#3641
edgarrmondragon merged 1 commit into
mainfrom
tox-up

Conversation

@edgarrmondragon
Copy link
Copy Markdown
Collaborator

@edgarrmondragon edgarrmondragon commented May 25, 2026

Summary by Sourcery

Update tooling versions and tox configuration used by project templates and CI resources.

Enhancements:

  • Raise the minimum tox version and tox-uv requirement in mapper, tap, and target cookiecutter templates.
  • Simplify tox env_list configuration in the cookiecutter template pyproject files.
  • Switch the nox templates session to use the explicit tox list command for environment discovery.

Build:

  • Bump the prek dependency version used in GitHub workflow resources.

…ation in templates

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner May 25, 2026 21:51
@edgarrmondragon edgarrmondragon self-assigned this May 25, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 25, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates tox-related configuration in all cookiecutter templates to require newer tox and tox-uv, simplifies the default env_list structure, bumps prek in GH workflow resources, and aligns the nox templates session with current tox CLI usage.

Sequence diagram for updated nox templates session tox usage

sequenceDiagram
    participant nox_session as nox.Session
    participant uvx
    participant prek
    participant tox

    nox_session->>uvx: session.run("uvx", "prek", "run", "--all-files")
    uvx->>prek: run

    nox_session->>uvx: session.run("uvx", "--with=tox-uv", "tox", "list")
    uvx->>tox: list

    nox_session->>uvx: session.run("uvx", "--with=tox-uv", "tox", "-e=typing")
    uvx->>tox: -e=typing
Loading

File-Level Changes

Change Details Files
Raise minimal tox/tox-uv versions and simplify env_list in all cookiecutter pyproject templates.
  • Increase tox minimal version requirement from 4.43 to 4.53 in template pyproject configurations.
  • Pin tox-uv to a minimal version (>=1.35) instead of an unversioned requirement.
  • Flatten env_list product configuration into a simpler prefix/start mapping for Python 3.x starting at 3.10.
cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/pyproject.toml
cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml
cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml
Update CI helper requirements to newer prek and adjust nox templates session tox invocation for new CLI.
  • Bump prek from 0.3.13 to 0.4.1 in workflow resources requirements to stay current with tooling.
  • Change the nox templates session to use tox list instead of legacy tox -l for listing environments while still running typing env afterward.
.github/workflows/resources/requirements.txt
noxfile.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The change from { product = [ { prefix = "3.", start = 10 }, ] } to { prefix = "3.", start = 10 } in the env_list alters the tox environment matrix structure; double-check that this simplified form still generates the intended set of Python environments with tox 4.53+.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The change from `{ product = [ { prefix = "3.", start = 10 }, ] }` to `{ prefix = "3.", start = 10 }` in the `env_list` alters the tox environment matrix structure; double-check that this simplified form still generates the intended set of Python environments with tox 4.53+.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.81%. Comparing base (4c0383c) to head (6917e6f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3641   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          73       73           
  Lines        5948     5948           
  Branches      729      729           
=======================================
  Hits         5580     5580           
  Misses        273      273           
  Partials       95       95           
Flag Coverage Δ
core 82.33% <ø> (ø)
end-to-end 75.21% <ø> (ø)
optional-components 42.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 25, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks


Comparing tox-up (6917e6f) with main (8848b02)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (4c0383c) during the generation of this report, so 8848b02 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@edgarrmondragon edgarrmondragon added this pull request to the merge queue May 25, 2026
Merged via the queue into main with commit 11fc5b5 May 25, 2026
41 checks passed
@edgarrmondragon edgarrmondragon deleted the tox-up branch May 25, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant