chore: Merge branch v0.53 into main#3603
Merged
Merged
Conversation
…json` in stream maps expressions (#3562) Backport of - #3560 ## Summary by Sourcery Constrain the simpleeval dependency version to avoid a breaking change in recent releases. Bug Fixes: - Pin simpleeval to versions below 1.0.5 to prevent regressions affecting stream maps expressions referencing modules. Build: - Adjust project dependency specification to restrict simpleeval to <1.0.5. Co-authored-by: Reuben <60552974+ReubenFrankel@users.noreply.github.com>
Prepare MeltanoSDK `v0.53.6` for release. Checklist: - [ ] Check that the right version is set in all the files. - [ ] Groom the changelog for wording or missing entries. - [ ] Merge this PR once everything looks good. [Release Draft](https://github.com/meltano/sdk/releases/tag/v0.53.6) ## Summary by Sourcery Release Meltano SDK version v0.53.6 and update project metadata accordingly. Bug Fixes: - Document a dependency constraint on simpleeval to avoid issues when using json in stream maps expressions. Enhancements: - Update all SDK version references across templates, documentation, and configuration files from 0.53.5 to 0.53.6. CI: - Update the default SDK version placeholder in the GitHub bug report template to 0.53.6. Documentation: - Add changelog entry for v0.53.6 describing the dependency constraint fix. Co-authored-by: edgarrmondragon <16805946+edgarrmondragon@users.noreply.github.com>
Signed-off-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
## Summary by Sourcery Update automation tooling and linters across CI workflows and development configuration to align with newer action and hook versions. Build: - Bump GitHub Actions versions for checkout, setup-python, artifact upload/download, Codecov, PyPI publish, CodeQL, dependency review, CodSpeed, and related workflow actions in all CI workflows. CI: - Refresh test, release, code scanning, benchmark, cookiecutter e2e, API change, dependency review, and security workflows to use newer pinned action SHAs and versions. Chores: - Update pre-commit hook revisions (check-jsonschema, uv-pre-commit, codespell, ruff) and adjust Ruff required-version in pyproject, along with a minor comment clean-up and uv.lock refresh. Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
…EvalWithCompoundTypes` (#3601) ## Related - #3561 - #3595 - Re-implements upstream danthedeckie/simpleeval#181 ## Summary by Sourcery Update stream mapper expression evaluation to be compatible with simpleeval 1.0.5+ while preserving the mapper’s existing safety guarantees. New Features: - Introduce a dedicated mapper expression evaluator subclass to control how AST nodes, names, and disallowed items are handled during evaluation. Bug Fixes: - Fix incompatibility with simpleeval 1.0.5+ by bypassing its new redundant container safety scan in a controlled way. Enhancements: - Wrap datetime and json modules with simpleeval.ModuleWrapper when exposing them as mapper functions to align with simpleeval’s safety model. Build: - Pin simpleeval to version 1.0.7 in project dependencies. Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
Prepare MeltanoSDK `v0.53.7` for release. Checklist: - [x] Check that the right version is set in all the files. - [x] Groom the changelog for wording or missing entries. - [ ] Merge this PR once everything looks good. [Release Draft](https://github.com/meltano/sdk/releases/tag/untagged-75a354aa6c663a60145a) ## Summary by Sourcery Prepare the v0.53.7 SDK release with updated version metadata and changelog entry. Bug Fixes: - Document support for simpleeval 1.0.5+ by subclassing simpleeval.EvalWithCompoundTypes. Documentation: - Add v0.53.7 section and fix description in the changelog. - Update docs configuration to reference release 0.53.7. Chores: - Bump singer-sdk version references from 0.53.6 to 0.53.7 across templates, tooling config, and issue templates. Co-authored-by: edgarrmondragon <16805946+edgarrmondragon@users.noreply.github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideVersion bump and release alignment for 0.53.7, updating templates, docs, and tooling metadata, plus adding a changelog entry for the simpleeval compatibility fix. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
v0.53 into main
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 73 73
Lines 5890 5890
Branches 723 723
=======================================
Hits 5521 5521
Misses 274 274
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/dependency-review.yml" line_range="26-27" />
<code_context>
- uses: actions/dependency-review-action@2031cfc080254a8a887f58cffee85186f0e49e48 # v4.9.0
if: ${{ github.event_name == 'pull_request' }}
with:
+ allow-ghsas: |
+ GHSA-44vg-5wv2-h2hg
fail-on-severity: high
</code_context>
<issue_to_address>
**🚨 suggestion (security):** Revisit the allowed GHSAs strategy to limit long-term exposure.
Allowing this GHSA may be necessary short term, but it risks becoming a long‑term blind spot. Please either add a periodic review step, scope the exemption to a specific version range, or document the rationale and removal criteria in the repo so it’s clear when and why this allowance should be revisited or removed.
Suggested implementation:
```
- uses: actions/dependency-review-action@2031cfc080254a8a887f58cffee85186f0e49e48 # v4.9.0
if: ${{ github.event_name == 'pull_request' }}
with:
# Temporary exemption for https://github.com/advisories/GHSA-44vg-5wv2-h2hg
# Rationale: <INSERT SHORT REASON WHY THIS CANNOT BE FIXED IMMEDIATELY>.
# Review policy:
# - Track this exemption in issue #<INSERT_ISSUE_ID>.
# - Revisit this exemption at least quarterly (or sooner if dependency is updated).
# - Remove once all affected dependencies are upgraded to a non-vulnerable version
# or the advisory is marked as not applicable.
# If this exemption is still needed after <INSERT_REVIEW_DEADLINE>, update the issue
# with the justification and a new review date.
allow-ghsas: |
GHSA-44vg-5wv2-h2hg
fail-on-severity: high
```
1. Replace the placeholders `<INSERT SHORT REASON WHY THIS CANNOT BE FIXED IMMEDIATELY>`, `#<INSERT_ISSUE_ID>`, and `<INSERT_REVIEW_DEADLINE>` with concrete values (e.g., specific blocked dependency, GitHub issue number tracking the exemption, and a calendar date for review).
2. Optionally, reference a central document (e.g., `docs/security-exemptions.md` or `SECURITY.md`) in the comments above so that the long-term policy for exemptions is documented and can be reviewed alongside this workflow.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
ada443c to
52f9463
Compare
Collaborator
Author
|
@sourcery-ai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Release version 0.53.7 and propagate the new version across changelog, templates, docs, and tooling configuration.
Bug Fixes:
Build:
Documentation:
Chores: