fix: Read input as bytes in MsgSpec Singer message reader#3140
Open
edgarrmondragon wants to merge 1 commit into
Open
fix: Read input as bytes in MsgSpec Singer message reader#3140edgarrmondragon wants to merge 1 commit into
edgarrmondragon wants to merge 1 commit into
Conversation
Contributor
Reviewer's GuideThis PR refactors MsgSpecReader to read and deserialize raw bytes from stdin instead of strings and enhances error reporting by formatting failed lines with repr. Class diagram for updated MsgSpecReader and related methodsclassDiagram
class GenericSingerReader~T~ {
}
class MsgSpecReader {
+default_input: IO[bytes]
+deserialize_json(line: bytes) dict
}
GenericSingerReader <|-- MsgSpecReader
Class diagram for deserialize_json method signature changeclassDiagram
class MsgSpecReader {
+deserialize_json(line: bytes) dict
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @edgarrmondragon - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3140 +/- ##
==========================================
- Coverage 92.30% 92.29% -0.02%
==========================================
Files 63 63
Lines 5343 5345 +2
Branches 677 677
==========================================
+ Hits 4932 4933 +1
- Misses 290 291 +1
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #3140 will not alter performanceComparing Summary
|
fc3272f to
48cc3d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Make MsgSpecReader consume raw bytes from stdin by updating its generic parameter, default_input, and deserialize_json signature, and improve error messaging
Bug Fixes:
Enhancements: