Skip to content

Indent output with 4 spaces and bugfix to write string for statistics #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Letme merged 3 commits into from
Sep 26, 2025
Merged

Indent output with 4 spaces and bugfix to write string for statistics #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08e8ed5
Update mlx.warnings as the new sphinx is taken which colors the output
Letme Sep 26, 2025
f596987
Add a raw comparison of the unit test and indent the output with 4 sp…
Letme Sep 26, 2025
e508f8b
Stylechecker cleanup
Letme Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mlx/unity2junit/unity2junit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ def generate_junit_xml(self):
timestamp = datetime.now(datetime.timezone.utc).isoformat()

# Create a default testsuite using extracted filename
ET.SubElement(testsuites, "testsuite", name=self.default_suite_name, errors="0", tests=self.total_tests,
failures=self.failures, skipped=self.skipped, timestamp=timestamp)
ET.SubElement(testsuites, "testsuite", name=self.default_suite_name, errors="0", tests=str(self.total_tests),
failures=str(self.failures), skipped=str(self.skipped), timestamp=timestamp)

for case in self.test_cases:
testsuite = ET.SubElement(
Expand All @@ -82,6 +82,7 @@ def generate_junit_xml(self):
)

tree = ET.ElementTree(testsuites)
ET.indent(tree, space=" ", level=0)
tree.write(self.output_file, encoding="utf-8", xml_declaration=True)
print(f"JUnit XML report generated: {self.output_file}")

Expand Down
19 changes: 19 additions & 0 deletions tests/test_in/utest_Init_Runner.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version='1.0' encoding='utf-8'?>
<testsuites>
<testsuite name="INIT" errors="0" tests="5" failures="0" skipped="0" timestamp="2025-09-25T13:40:24.403458+00:00" />
<testsuite name="INIT.SWUTEST_INIT-TEST_INIT_SUCCESS" timestamp="2025-09-25T13:40:24.403458+00:00" time="0.0" errors="0" tests="1" failures="0" skipped="0">
<testcase name="SWUTEST_INIT-TEST_INIT_SUCCESS" classname="INIT.SWUTEST_INIT-TEST_INIT_SUCCESS" time="0.0" />
</testsuite>
<testsuite name="INIT.SWUTEST_INIT-TEST_INIT_WRONG_EEPROM_VERSION" timestamp="2025-09-25T13:40:24.403458+00:00" time="0.0" errors="0" tests="1" failures="0" skipped="0">
<testcase name="SWUTEST_INIT-TEST_INIT_WRONG_EEPROM_VERSION" classname="INIT.SWUTEST_INIT-TEST_INIT_WRONG_EEPROM_VERSION" time="0.0" />
</testsuite>
<testsuite name="INIT.SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS" timestamp="2025-09-25T13:40:24.403458+00:00" time="0.0" errors="0" tests="1" failures="0" skipped="0">
<testcase name="SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS" classname="INIT.SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS" time="0.0" />
</testsuite>
<testsuite name="INIT.SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS2" timestamp="2025-09-25T13:40:24.403458+00:00" time="0.0" errors="0" tests="1" failures="0" skipped="0">
<testcase name="SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS2" classname="INIT.SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS2" time="0.0" />
</testsuite>
<testsuite name="INIT.SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS3" timestamp="2025-09-25T13:40:24.403458+00:00" time="0.0" errors="0" tests="1" failures="0" skipped="0">
<testcase name="SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS3" classname="INIT.SWUTEST_INIT-TEST_INIT_I2C_READ_FAILS3" time="0.0" />
</testsuite>
</testsuites>
22 changes: 21 additions & 1 deletion tests/unity_parsing_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
''' Test suite for functions that set the prefix and prefix_set variables '''
import unittest
import tempfile
from unittest.mock import patch
from pathlib import Path

from datetime import datetime, timezone
from mlx.unity2junit.unity2junit import Unity2Junit

TEST_IN_DIR = Path(__file__).parent / 'test_in'
Expand Down Expand Up @@ -122,6 +123,25 @@ def test_parsing_unity_log_and_building_testcases_failed(self):
self.assertEqual(converter.failures, 1)
self.assertEqual(converter.skipped, 0)

def test_init_runner_output(self):
'''Verify that utest_Init_Runner.log is converted to utest_Init_Runner.xml on a fixed timestamp of
2025-09-25T13:40:24.403458+00:00'''
fixed_timestamp_str = "2025-09-25T13:40:24.403458" # Taken from utest_Init_Runner.xml
fixed_datetime = datetime.fromisoformat(fixed_timestamp_str).replace(tzinfo=timezone.utc)
expected_xml = ''

with open(TEST_IN_DIR / 'utest_Init_Runner.xml', 'r', encoding='utf-8') as f:
expected_xml = f.readlines()

with tempfile.NamedTemporaryFile(mode='w+', delete=True, encoding='utf-8') as tmp_output_file:
with patch('mlx.unity2junit.unity2junit.datetime') as mock_dt:
mock_dt.now.return_value = fixed_datetime
converter = Unity2Junit(TEST_IN_DIR / 'utest_Init_Runner.log', tmp_output_file.name)
converter.convert()
tmp_output_file.seek(0)
generated_xml = tmp_output_file.readlines()
self.assertListEqual(generated_xml, expected_xml)


if __name__ == '__main__':
unittest.main()
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ deps=
{[testenv]deps}
sphinx
sphinx_rtd_theme
mlx.warnings >= 5.0.0
mlx.warnings >= 6.1.1
allowlist_externals =
bash
make
Expand Down