fix(e2e): wait for the options save before navigating away - #173
Merged
Conversation
Both Save options clicks in the Tokyo timezone test fired a Server Action and navigated immediately, so a slow response stream was aborted by the next goto and the board logged 'The destination stream closed early' — which the server-error reporter rightly fails the run for. Awaiting the ?saved=1 redirect pins the order: the save completes, then the navigation happens. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011TkUEQhzDEpjYSgJLqeBDb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kills the e2e flake that failed shard 2 twice today (on
mainat run #495 and on #170's first run): the Tokyo timezone test clicked Save options and navigated away immediately, so when the runner was slow the Server Action's response stream was aborted mid-flight and the board logged⨯ Error: The destination stream closed early(digest1663937324) — which the server-error reporter rightly fails the run for, twice per run because the test saves twice.The fix awaits the
?saved=1redirect after each save before navigating, the same pattern thesignUphelper already uses with/login?registered=1. The save now provably completes before the nextgotocan cancel it.Validated locally: the three
local-timetests pass with no server errors logged. This was meant to ride along on #170, which merged first.🤖 Generated with Claude Code
https://claude.ai/code/session_011TkUEQhzDEpjYSgJLqeBDb
Generated by Claude Code