Skip to content

Replace remove_missing by Base.nonmissingtype #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meggart merged 1 commit into from
Jan 28, 2025
Merged

Replace remove_missing by Base.nonmissingtype #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/DiskArrayTools.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,6 @@ function resample_disk_dimkw(a::AggregatedDiskArray,aout,atemp2,parentranges)
end


remove_missing(::Type{T}) where T <: Union{Missing, T2} where T2 = T2

#Use of Sentinel missing value
struct CFDiskArray{T,N,MT,P,OT} <: AbstractDiskArray{T,N}
a::P
Expand All @@ -227,7 +225,7 @@ function CFDiskArray(a::AbstractArray{T}, attr::Dict) where T
offs, sc = if haskey(attr, "add_offset") || haskey(attr, "scale_factor")
_offs = get(attr, "add_offset", false)
_sc = get(attr, "scale_factor", true)
T2 = remove_missing(T)
T2 = Base.nonmissingtype(T)
if _offs isa AbstractFloat && _sc isa AbstractFloat && T2 <: AbstractFloat
T2(_offs), T2(_sc)
else
Expand Down
Loading