Skip to content

Reduce manual pre-installation requirements via pyproject.toml #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2022
Merged

Reduce manual pre-installation requirements via pyproject.toml #162

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7771e2
Add pyproject.toml
nrontsis Dec 9, 2022
3fc58ae
Fix syntax
nrontsis Dec 9, 2022
b3f5886
Add version specification for setuptools
nrontsis Dec 9, 2022
29f5f53
Specify build-backend
nrontsis Dec 9, 2022
10e2e48
Reduce pre-installation requirements in docs
nrontsis Dec 9, 2022
3bc2708
Reduce diff
nrontsis Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/source/install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ dependencies:
* pkg-config [only for Linux and Mac]
* Ipopt [>= 3.13 on Windows]
* Python 3.6+
* setuptools
* cython
* numpy
* scipy [optional]
Copy link
Collaborator

@moorepants moorepants Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've also removed scipy here as an optional dep. How does pyproject.toml handle that?

Copy link
Contributor Author

@nrontsis nrontsis Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the scipy interface of cyipopt is not related to the build process, so it has no place in build requiremetns.

Copy link
Collaborator

@moorepants moorepants Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is a list of all build and run time dependencies (optional or not). I'd like to leave the list intact in the documentation.

Copy link
Contributor Author

@nrontsis nrontsis Dec 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have restored the diff here, but I find that docs confusing. They say:

To begin installing from source you will need to install the following dependencies

So I don't understand them to be "build or run time depedencies" necessarily.

Furthermore, no versions are specified here, which is inconsistent with what setup.py requires.


The binaries and header files of the Ipopt package can be obtained from
http://www.coin-or.org/download/binary/Ipopt/. These include a version compiled
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["cython >= 0.26", "numpy >= 1.15", "setuptools>=39.0"]
build-backend = "setuptools.build_meta"