Add CSS carousel examples #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. |
pepelsbey
requested changes
Aug 5, 2025
There was a problem hiding this comment.
Looks good! Though I found an issue with viewport units and scroll bars. It’s better to avoid using 100vw at any cost, since it’s the viewport width, not the “window content apart from scrollbars” width. And the moment you have vertical scrollbars, you’ll get this:
You can check this by setting your scrollbars to be visible by default, not overlay content:
So I would suggest using 100% instead of 100vw. Unfortunately, with the full-width panels, it doesn’t play nicely with flexbox, so I used a grid layout instead:
display: grid;
grid-auto-flow: column;
grid-auto-columns: 100%;
gap: 4%;
css-carousels/scroll-button-scroll-marker-with-columns/styles.css
Outdated
Show resolved
Hide resolved
Co-authored-by: Vadim Makeev <[email protected]>
Co-authored-by: Vadim Makeev <[email protected]>
|
Makes sense; thanks @pepelsbey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am in the process of documenting the new CSS Carousels functionality on MDN (see mdn/content#38752).
I have included the examples as live examples in the guide, but I also want to link to standalone live examples and source code, as they are not as easy to follow in-page.