Skip to content

service-worker: await unnecessary, errors should be handled #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

service-worker: await unnecessary, errors should be handled #254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
685ffa2
await unnecessary, errors should be handled
sidewayss Feb 3, 2024
aab53f9
err.stack includes err.toString()
sidewayss Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions service-worker/simple-service-worker/sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
const addResourcesToCache = async (resources) => {
const cache = await caches.open('v1');
await cache.addAll(resources);
cache.addAll(resources).catch(err => console.error(err.stack ?? err));
};

const putInCache = async (request, response) => {
const cache = await caches.open('v1');
await cache.put(request, response);
cache.put(request, response).catch(err => console.error(err.stack ?? err));
};

const cacheFirst = async ({ request, preloadResponsePromise, fallbackUrl }) => {
Expand Down