Skip to content

FF142 Relnote Animation.commitStyles no longer requires fill #40611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamishwillee
Copy link
Collaborator

FF142 Animation/commitStyles() allows animations to capture the final styles without specifying a fill in latest spec - in https://bugzilla.mozilla.org/show_bug.cgi?id=1973203

This adds a release note.

Related docs work in #40482

@hamishwillee hamishwillee requested a review from a team as a code owner August 4, 2025 02:08
@hamishwillee hamishwillee requested review from dipikabh and removed request for a team August 4, 2025 02:08
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Aug 4, 2025
@@ -53,6 +53,7 @@ Firefox 142 is the current [Beta version of Firefox](https://www.firefox.com/en-
#### DOM

- The {{domxref("Selection.getComposedRanges()")}} method is now supported, allowing developers to accurately get selected text ranges across shadow DOM boundaries. In addition, the methods {{domxref("Selection.setBaseAndExtent()","setBaseAndExtent()")}}, {{domxref("Selection.collapse()","collapse()")}}, and {{domxref("Selection.extend()","extend()")}} of the {{domxref("Selection")}} interface have been modified to accept nodes inside a shadow root. ([Firefox bug 1903870](https://bugzil.la/1903870)).
- The {{domxref("Animation.commitStyles()")}} method no longer requires that [`fill`](/en-US/docs/Web/API/KeyframeEffect/KeyframeEffect#fill) is set on an animation in order to commit the computed styles after the animation has finished. Note that until more browsers support this change, code should continue to set `fill`. ([Firefox bug 19197320303870](https://bugzil.la/1973203)).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, note the bit "Note that until more browsers support this change, code should continue to set fill.".
I wouldn't normally write this, but you can't feature check for this change, so it won't be useful until most browsers support this.

Copy link
Contributor

github-actions bot commented Aug 4, 2025

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/142
Title: Firefox 142 for developers

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -53,6 +53,7 @@ Firefox 142 is the current [Beta version of Firefox](https://www.firefox.com/en-
#### DOM

- The {{domxref("Selection.getComposedRanges()")}} method is now supported, allowing developers to accurately get selected text ranges across shadow DOM boundaries. In addition, the methods {{domxref("Selection.setBaseAndExtent()","setBaseAndExtent()")}}, {{domxref("Selection.collapse()","collapse()")}}, and {{domxref("Selection.extend()","extend()")}} of the {{domxref("Selection")}} interface have been modified to accept nodes inside a shadow root. ([Firefox bug 1903870](https://bugzil.la/1903870)).
- The {{domxref("Animation.commitStyles()")}} method no longer requires that [`fill`](/en-US/docs/Web/API/KeyframeEffect/KeyframeEffect#fill) is set on an animation in order to commit the computed styles after the animation has finished. Note that until more browsers support this change, code should continue to set `fill`. ([Firefox bug 19197320303870](https://bugzil.la/1973203)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can drop a few words to make it more compact. Also, there's a typo in the bug number

Suggested change
- The {{domxref("Animation.commitStyles()")}} method no longer requires that [`fill`](/en-US/docs/Web/API/KeyframeEffect/KeyframeEffect#fill) is set on an animation in order to commit the computed styles after the animation has finished. Note that until more browsers support this change, code should continue to set `fill`. ([Firefox bug 19197320303870](https://bugzil.la/1973203)).
- The {{domxref("Animation.commitStyles()")}} method no longer requires [`fill`](/en-US/docs/Web/API/KeyframeEffect/KeyframeEffect#fill) to be set on an animation to commit the computed styles after the animation has finished. Note that until more browsers support this change, you should continue to set `fill`. ([Firefox bug 1973203](https://bugzil.la/1973203)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants