Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
left a comment
There was a problem hiding this comment.
LGTM, but I would reframe the PR title to removing these obsolete CSS features.
Not mandatory, but with PR stacks you could have the bottom PR removing the obsolete CSS features, another one on top that updates the non-obsolete CSS features, and a third one that removes the obsolete lint. This is slightly more work when doing these changes all manually, but simplifies the reviews, and allows to merge them all together (in three separate commits) when all are approved.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
✖ css.types.param.url - Error → feature was never implemented. This was recently added and even minted to a web-feature (that's why I had merge conflicts). This PR removes these keys again. cc @ddbeck who reviewed web-platform-dx/web-features#4322 |
Summary
Right now, our irrelevance guideline is not applied to the
css/folder because the lint has been disabled (from the start when we first implemented this rule, there were just too many data points to clean up at the time). We're now down to 25 entries there and I think it is time to finally enable this lint for CSS, too.If you enable the lint on main you get the following messages:
I removed all of these except for:
Test results and supporting details
Improved linting now passes for the CSS folder.
Future lints will prevent authors from adding all-false CSS features.
Related issues
None, I think.
Fixes #29834.