Add table_cells entry for writing-mode iOS Safari compatibility - #30276
Open
r4-rahul123 wants to merge 6 commits into
Open
r4-rahul123 wants to merge 6 commits into
r4-rahul123 wants to merge 6 commits into
Conversation
github-actions
Bot
added
data:css
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Contributor
|
The lint check found auto-fixable issues. Apply suggested changes (attributed to |
- Changed description from 'Applies to <th> and <td> elements' to 'Applies to table cell elements' - Changed notes from 'Not supported on <th> or <td> elements before iOS 17.' to 'Not supported on table cell elements before iOS 17.' BCD linter only allows code, kbd, em, strong, a HTML elements in notes.
Remove redundant notes field from safari_ios entry to fix BCD linter error.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+476
to
+513
| "table_cells": { | ||
| "__compat": { | ||
| "description": "Applies to table cell elements", | ||
| "tags": [ | ||
| "web-features:writing-mode" | ||
| ], | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "48" | ||
| }, | ||
| "chrome_android": "mirror", | ||
| "edge": { | ||
| "version_added": "12" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "43" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": "9" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "17" | ||
| }, | ||
| "samsunginternet_android": "mirror", | ||
| "webview_android": "mirror", | ||
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
[bcd-linter] reported by reviewdog 🐶
Suggested change
| "table_cells": { | |
| "__compat": { | |
| "description": "Applies to table cell elements", | |
| "tags": [ | |
| "web-features:writing-mode" | |
| ], | |
| "support": { | |
| "chrome": { | |
| "version_added": "48" | |
| }, | |
| "chrome_android": "mirror", | |
| "edge": { | |
| "version_added": "12" | |
| }, | |
| "firefox": { | |
| "version_added": "43" | |
| }, | |
| "firefox_android": "mirror", | |
| "oculus": "mirror", | |
| "opera": "mirror", | |
| "opera_android": "mirror", | |
| "safari": { | |
| "version_added": "9" | |
| }, | |
| "safari_ios": { | |
| "version_added": "17" | |
| }, | |
| "samsunginternet_android": "mirror", | |
| "webview_android": "mirror", | |
| "webview_ios": "mirror" | |
| }, | |
| "status": { | |
| "experimental": false, | |
| "standard_track": true, | |
| "deprecated": false | |
| } | |
| } | |
| }, |
Contributor
There was a problem hiding this comment.
This looks like the JSON file is not properly formatted, specifically not properly ordered (though the automated review missed to post a separate comment for adding this feature further above).
Please run npm run lint:fix -- css/properties/writing-mode.json locally to resolve this.
Remove web-features tag from subfeature and add ie support for BCD linter compliance.
Comment on lines
+476
to
+513
| "table_cells": { | ||
| "__compat": { | ||
| "description": "Applies to table cell elements", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "48" | ||
| }, | ||
| "chrome_android": "mirror", | ||
| "edge": { | ||
| "version_added": "12" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "43" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "ie": { | ||
| "version_added": "9" | ||
| }, | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": "9" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "17" | ||
| }, | ||
| "samsunginternet_android": "mirror", | ||
| "webview_android": "mirror", | ||
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
[bcd-linter] reported by reviewdog 🐶
Suggested change
| "table_cells": { | |
| "__compat": { | |
| "description": "Applies to table cell elements", | |
| "support": { | |
| "chrome": { | |
| "version_added": "48" | |
| }, | |
| "chrome_android": "mirror", | |
| "edge": { | |
| "version_added": "12" | |
| }, | |
| "firefox": { | |
| "version_added": "43" | |
| }, | |
| "firefox_android": "mirror", | |
| "ie": { | |
| "version_added": "9" | |
| }, | |
| "oculus": "mirror", | |
| "opera": "mirror", | |
| "opera_android": "mirror", | |
| "safari": { | |
| "version_added": "9" | |
| }, | |
| "safari_ios": { | |
| "version_added": "17" | |
| }, | |
| "samsunginternet_android": "mirror", | |
| "webview_android": "mirror", | |
| "webview_ios": "mirror" | |
| }, | |
| "status": { | |
| "experimental": false, | |
| "standard_track": true, | |
| "deprecated": false | |
| } | |
| } | |
| }, |
caugner
reviewed
Sep 3, 2026
Comment on lines
+476
to
+478
| "table_cells": { | ||
| "__compat": { | ||
| "description": "Applies to table cell elements", |
Contributor
There was a problem hiding this comment.
For consistency, this could be renamed to:
Suggested change
| "table_cells": { | |
| "__compat": { | |
| "description": "Applies to table cell elements", | |
| "vertical_oriented_table_cells": { | |
| "__compat": { | |
| "description": "Vertically-oriented table cells", |
Comment on lines
+480
to
+502
| "chrome": { | ||
| "version_added": "48" | ||
| }, | ||
| "chrome_android": "mirror", | ||
| "edge": { | ||
| "version_added": "12" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "43" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "ie": { | ||
| "version_added": "9" | ||
| }, | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": "9" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "17" | ||
| }, |
Contributor
There was a problem hiding this comment.
This seems to assume all browsers supported table cells from the beginning. It would probably be best to verify this in BrowserStack Live with a small JSBin.
Author
|
@caugner Thanks for the review and suggestions! I have renamed the feature key to Please let me know if any further adjustments are needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29241
This PR adds a new compatibility entry documenting that
writing-mode: vertical-*does not work on<th>or<td>elements on iOS Safari before version 17.The current data shows
safari_ios: "mirror"which incorrectly implies full support from iOS 9+. In reality, table cell elements only received support starting from iOS 17.