Dockerfile and some fixes for ECR#7
Open
tomaszkiewicz wants to merge 5 commits intomdlavin:masterfrom
Open
Conversation
Owner
|
I've been horrible for not responding faster. How would you feel about taking over the project? I should be able to give you permission to merge and I can give you access to publish on npm too. Would you be interested in that? |
Contributor
Author
|
I've encountered some issues related to my fixes of manifest - it looks like in some cases docker refuses to use the image as the signature is invalid, unfortunately I haven't figured out the solution yet :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As I've promised I'm opening a pull request with the rest of my changes, I mean:
The change number 2 is not backward compatible.
I understand that you can reject this PR to be backward compatible and it's ok :)
Best regards
Łukasz Tomaszkiewicz