Skip to content

Add support for web version of application #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onufriievkyrylo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for web version of application #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67154e0
add browser
Jan 31, 2018
f23a5e7
fix tests
Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/public/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function deepLink(options) {
androidPackageName +
';end;',
playStoreLink: playStoreLink,
fallback: fallback
fallback: fallback + '/' + path
};

var isMobile = {
Expand Down
8 changes: 5 additions & 3 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const device = require('./lib/device');
const Browser = require('./lib/browser');

const url = 'app://test/';
const path = url.split(/:\/\/(.+)/)[1];
const fallback = 'https://vandelay.com/';
const androidPackageName = 'ind.vandelay.art';
const iosStoreLink =
Expand Down Expand Up @@ -43,7 +44,8 @@ describe('android', () => {
fallback: fallback
},
res => {
assert.equal(res, fallback);
console.log(res);
assert.equal(res, fallback + '/' + path);
done();
}
);
Expand Down Expand Up @@ -82,7 +84,7 @@ describe('ios', () => {
fallback: fallback
},
res => {
assert.equal(res, fallback);
assert.equal(res, fallback + '/' + path);
done();
}
);
Expand All @@ -109,7 +111,7 @@ describe('general', () => {
android_package_name: androidPackageName
},
res => {
assert.equal(res, fallback);
assert.equal(res, fallback + '/' + path);
done();
}
);
Expand Down