Merged
Conversation
[skip ci]
There was a problem hiding this comment.
Pull request overview
This PR improves database creation performance by switching most graph property computations from NetworkX to igraph, while keeping NetworkX only for planarity checking (since igraph doesn’t support it yet). It addresses Issue #21 by significantly reducing the time needed to generate the maximal database (up to n < 9).
Changes:
- Replaced NetworkX-based Hamiltonian and degree utilities with igraph equivalents and added an igraph-based Eulerian check.
- Updated database creation to convert graph6 → NetworkX → igraph, computing most properties with igraph and planarity with NetworkX.
- Updated docs and dependencies to include igraph and reflect new runtime expectations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/graphreveal/db_creator/util.py |
Migrates helper algorithms from NetworkX to igraph and adds is_eulerian. |
src/graphreveal/db_creator/create.py |
Uses igraph for most properties during DB creation, retaining NetworkX only for planarity. |
README.md |
Updates expected database creation timings and wording. |
pyproject.toml |
Adds igraph as a project dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The igraph library does not support planarity checks, so we leave that to networkx for now. All other properties are checked with igraph.
Thanks to this change, creating the maximal database ($n \leq 9$ ) now takes 2 minutes (instead of 25 minutes).
Resolve #21.