Adds Ming Image support - #1553
Merged
Merged
Conversation
| } | ||
| else if (IsMingImage() && isPositive && GetPromptImage(false, true) is JArray mingImage) | ||
| { | ||
| string resized = CreateNode("ImageScale", new JObject() |
Member
There was a problem hiding this comment.
use the scaling in GetPromptImage, not this
| } | ||
| inputs[$"images.image_{i + 1}"] = image2; | ||
| } | ||
| node = CreateNode("TextEncodeMingImageEdit", inputs, id); |
Member
There was a problem hiding this comment.
Model-specific textencode nodes are really undesirable at this point with how much the swarm node handles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does NOT include Ming Image Layer support because that's a whole other can of worms.
Note: I had to use AI assistance for matching the VAE headers in
isMingImageVae, reset metadata, no conflicts.