allow d3 major versions after 4#13
Open
stevvvn wants to merge 1 commit intomcaule:masterfrom
stevvvn:allow-new-d3-major-versions
Open
allow d3 major versions after 4#13stevvvn wants to merge 1 commit intomcaule:masterfrom stevvvn:allow-new-d3-major-versions
stevvvn wants to merge 1 commit intomcaule:masterfrom
stevvvn:allow-new-d3-major-versions
Conversation
|
Does not work in the latest v7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library works fine with d3 v5.x, however if you install it in a project already using v5 for something it brings in a v4 copy because the ^ listed in the dependency version doesn't allow traversing major versions. This ends up causing an errors related to d3-selection annotating properties of the wrong version.
This patch should allow it to work in v4 or v5 equally.