mps-cli-py: complete binary (.mpb) persistency implementation#54
Draft
Prithvi686 wants to merge 14 commits intomainfrom
Draft
mps-cli-py: complete binary (.mpb) persistency implementation#54Prithvi686 wants to merge 14 commits intomainfrom
Prithvi686 wants to merge 14 commits intomainfrom
Conversation
- Refactored binary persistency implementation to separate constants, low-level reader utilities. - Fixed model header parsing to correctly handle model-reference kind vs model-id kind according to MPS binary persistency format. - Correctly reconstruct model UUID with 'r:' prefix. - Updated low-level test expectations to reflect fully- qualified model names.
… persistency and added low-level tests covering imports
… read_reference - Integrated node loading into SModelBuilderBinaryPersistency - Added root_nodes structure - Extended tests to validate full model tree parsing
…rchitecture - Removed registry dict usage - Integrated index_2_* maps from base builder - Construct real SConcept, SProperty, SNode instances - Unified binary builder structure with XML persistency - Updated tests to validate object-based model structure
- Implement full binary (.mpb) model parsing - Load model header, registry, used languages and imports - Build concept/property/reference/containment index maps - Parse node tree including containment roles and properties - Added support for reference kind validation and resolve_info - Applied node id encoding during parsing - Added repository-level completeness and resolution tests
…ode ids and also corrected existing test case failure
…nodes.py to fix the failing test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented full support for binary (.mpb) model persistency:
Added model header, registry, imports, and node parsing
Implemented reference handling and resolve support
Ensured correct parent/containment relationships
Added comprehensive unit and integration tests