ci: add cargo tests by fffonion · Pull Request #89 · mayocream/koharu

fffonion · 2025-12-13T17:36:34Z

No description provided.

gemini-code-assist · 2025-12-13T17:36:49Z

Summary of Changes

Hello @fffonion, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on adjusting the existing test suite, likely in preparation for or as part of integrating cargo test into the continuous integration pipeline. It includes refactoring a comic text detector test for better organization and debugging, updating its model loading mechanism, and temporarily disabling an FFT-related test.

Highlights

Test Refactoring: The comic_text_detector test has been refactored, moving it into a dedicated test module and adding tracing::instrument for improved debugging and observability.
Test Parameter Update: The ComicTextDetector::load call within the test was updated to simplify device selection by directly passing a boolean value.
Test Disablement: An existing FFT roundtrip test in lama/fft/mod.rs was temporarily commented out.

Ignored Files

Ignored by pattern: .github/workflows/** (5)
- .github/workflows/build.yml
- .github/workflows/lint.yml
- .github/workflows/パブリッシュ.yml
- .github/workflows/リリース.yaml
- .github/workflows/継続的インテグレーション.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request aims to add cargo tests for CI. It modifies two files: one by commenting out an existing test module, and another by refactoring an integration test. My review focuses on these changes. I've pointed out that commenting out tests is an anti-pattern and suggest removing the code or using #[ignore]. I've also suggested simplifying the integration test structure by removing a redundant module wrapper, which is not idiomatic for integration tests in Rust.

Copilot

Pull request overview

This PR integrates cargo tests into the CI pipeline by consolidating existing workflow files and modifying the comic text detector test structure. The PR removes the separate lint.yml and build.yml workflow files in favor of a unified approach that includes running cargo test in the koharu-ml workspace.

Key changes:

Restructured the comic text detector test to use a test module with tracing instrumentation
Simplified the test by passing false directly to ComicTextDetector::load() instead of managing device selection
Commented out the FFT roundtrip test in the lama module

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

File	Description
koharu-ml/tests/comic_text_detector.rs	Refactored test into a proper test module structure with tracing instrumentation and simplified device handling
koharu-ml/src/lama/fft/mod.rs	Commented out the FFT roundtrip unit test
.github/workflows/lint.yml	Deleted workflow file (consolidated into main CI workflow)
.github/workflows/build.yml	Deleted workflow file (consolidated into main CI workflow)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-13T17:45:01Z

@mayocream I've opened a new pull request, #90, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

.github/workflows/release-packages.yaml:18

The job name has been changed to Japanese characters ("マイクロソフトウィンドウズ"). Using non-English characters in CI job names can cause issues with some CI/CD tools, reduces accessibility for international teams, and makes logs harder to search. Consider using English names like "Build - Windows" for better compatibility and maintainability.
.github/workflows/release-packages.yaml:74
The job name has been changed to Japanese characters ("マックオーエス"). Using non-English characters in CI job names can cause issues with some CI/CD tools, reduces accessibility for international teams, and makes logs harder to search. Consider using English names like "Build - macOS" for better compatibility and maintainability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 12 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Removed test job and concurrency settings from build workflow.

This workflow runs integration tests on pushes to the main branch and pull requests.

Copilot

Pull request overview

Copilot reviewed 8 out of 13 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 8 out of 13 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 13 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 13, 2025 17:36

Copilot started reviewing on behalf of fffonion December 13, 2025 17:36 View session

gemini-code-assist Bot reviewed Dec 13, 2025

View reviewed changes

Comment thread koharu-ml/src/lama/fft/mod.rs Outdated

Comment thread koharu-ml/tests/comic_text_detector.rs Outdated

Copilot AI reviewed Dec 13, 2025

View reviewed changes

Comment thread koharu-ml/tests/comic_text_detector.rs Outdated

Comment thread koharu-ml/src/lama/fft/mod.rs Outdated

mayocream reviewed Dec 13, 2025

View reviewed changes

Comment thread koharu-ml/tests/comic_text_detector.rs Outdated

Copilot AI mentioned this pull request Dec 13, 2025

Add copilot:ignore annotation to suppress false positive review comment #90

Closed

fffonion force-pushed the ci branch from 9b53f44 to f533394 Compare December 13, 2025 17:57

Copilot AI review requested due to automatic review settings December 13, 2025 18:04

fffonion force-pushed the ci branch from f533394 to cb053fe Compare December 13, 2025 18:04

Copilot started reviewing on behalf of fffonion December 13, 2025 18:04 View session

fffonion force-pushed the ci branch from cb053fe to 7448d13 Compare December 13, 2025 18:05

Copilot AI reviewed Dec 13, 2025

View reviewed changes

Comment thread .github/workflows/lint.yml

mayocream reviewed Dec 13, 2025

View reviewed changes

Comment thread .github/workflows/release-packages.yaml Outdated

mayocream reviewed Dec 13, 2025

View reviewed changes

Comment thread .github/workflows/release-packages.yaml Outdated

ci: add cargo tests

ad539bd

fffonion force-pushed the ci branch from 7448d13 to ad539bd Compare December 13, 2025 18:07

mayocream reviewed Dec 13, 2025

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Apply suggestion from @mayocream

06bb639

Copilot AI review requested due to automatic review settings December 13, 2025 18:21

Apply suggestion from @mayocream

c10a7b7

Copilot started reviewing on behalf of mayocream December 13, 2025 18:22 View session

mayocream added 2 commits December 14, 2025 03:22

Rename test.yml to build.yml

8efa1dc

Apply suggestion from @mayocream

85aa6ec

mayocream reviewed Dec 13, 2025

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Apply suggestion from @mayocream

d22abde

Copilot AI reviewed Dec 13, 2025

View reviewed changes

Comment thread koharu-ml/tests/ocr.rs Outdated

Comment thread koharu-ml/tests/comic_text_detector.rs Outdated

Simplify build workflow by removing test job

a296375

Removed test job and concurrency settings from build workflow.

Copilot AI review requested due to automatic review settings December 13, 2025 18:26

Copilot started reviewing on behalf of mayocream December 13, 2025 18:26 View session

Add GitHub Actions workflow for integration tests

570b010

This workflow runs integration tests on pushes to the main branch and pull requests.

Copilot AI reviewed Dec 13, 2025

View reviewed changes

Comment thread .github/workflows/lint.yml Outdated

Comment thread .github/workflows/lint.yml Outdated

Refactor lint workflow configuration

d218f36

Copilot AI review requested due to automatic review settings December 13, 2025 18:30

Copilot started reviewing on behalf of mayocream December 13, 2025 18:31 View session

Refactor comic_text_detector test for async usage

3675905

Copilot AI reviewed Dec 13, 2025

View reviewed changes

Comment thread koharu-ml/tests/comic_text_detector.rs Outdated

Refactor OCR test to remove unnecessary nesting

6b22081

Copilot AI review requested due to automatic review settings December 13, 2025 18:35

Copilot started reviewing on behalf of mayocream December 13, 2025 18:35 View session

mayocream and others added 2 commits December 14, 2025 03:36

Refactor LLM test for async execution

51a1cf3

Apply suggestion from @Copilot

2524d9b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Dec 13, 2025

View reviewed changes

Comment thread koharu-ml/src/lama/fft/cpu.rs

mayocream added 3 commits December 14, 2025 03:39

Refactor inpainting test for clarity and conciseness

5ddaa81

Rename release-packages.yaml to release.yaml

bbdad89

Rename publish-crates-io.yml to publish.yml

0e255e7

mayocream approved these changes Dec 13, 2025

View reviewed changes

mayocream merged commit 693bf07 into main Dec 13, 2025
3 of 4 checks passed

mayocream deleted the ci branch December 13, 2025 18:48

Uh oh!

Conversation

fffonion commented Dec 13, 2025

Uh oh!

gemini-code-assist Bot commented Dec 13, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Dec 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants