Merge auto-render ops with the op just before it#856
Open
obsgolem wants to merge 1 commit into
Open
Conversation
This ensures that auto-render is considered as part of a batch edit, thus preventing situations where ctrl-z appears to have no effect. Fixes: mayocream#852
obsgolem
requested review from
Map1en,
fffonion,
karrot0,
liksunrice and
mayocream
as code owners
July 10, 2026 02:51
Owner
|
This would work, but I wonder if we can "batch" auto-render with the previous op. 🤔 |
Contributor
Author
The problem is the debouncing. The previous op needs to apply before the ui can update, so we can't afford to wait a debounce cycle. Thus my idea to merge it later and pretend like it was a batch in the first place. |
Collaborator
|
I think #801 fixed it via batching with previous op |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that auto-render is considered as part of a batch edit, thus preventing situations where ctrl-z appears to have no effect.
Note that I don't update the record on-disk, so when reloading it will be treated as a separate entry. Let me know if you want me to try to figure out a way to resolve this as part of the MR.
Fixes: #852
No AI was used in this MR.