feat: Add JSON import / export of source and translation text#829
Open
spaghetti-stack wants to merge 1 commit into
Open
feat: Add JSON import / export of source and translation text#829spaghetti-stack wants to merge 1 commit into
spaghetti-stack wants to merge 1 commit into
Conversation
spaghetti-stack
requested review from
Map1en,
fffonion,
karrot0,
liksunrice and
mayocream
as code owners
June 28, 2026 16:19
|
Thanks for your first PR to Koharu. Please review our contribution guide before review: In the PR description, include:
If AI helped produce the patch, a human still needs to review and understand it before submission. |
Allows exporting source and translation text of a whole project to JSON format. Allows importing translation text for a whole project in JSON format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This way it is now possible to use an external translation provider to, for example:
This feature is similar to #614 and #555 (but without speaker ID).
I chose JSON as format because it is easy to parse, and the format is (slightly) more compact than XML so using an LLM for whole context translation would use less tokens. XML or Markdown could also be added in the future.
User facing changes:
Added the "Export source texts", "Export translations" and "Import translations" buttons to the UI which are used to interact with this new feature.
Testing
I have manually tested the import / export functionality. There are also front end and back end unit tests.