Quality: RegionExt::clamp returns spurious 1×1 crop when region is entirely outside image bounds - #826
Open
kumburovicbranko682-boop wants to merge 1 commit into
Conversation
…ntirely outside image bounds When a Region is completely outside the image (e.g., self.x=100 on a 50-wide image), the clamp method incorrectly returns Some((49, y0, 1, h)) — a 1-pixel strip at the boundary — instead of None. This happens because x0 is capped at width-1 (49), then x1 is computed as max(..., x0)=50, yielding w=1. The caller has no way to know the region was entirely out-of-bounds and will silently crop a wrong sliver of the image. Affected files: utils.rs Signed-off-by: kumburovicbranko682-boop <295886834+kumburovicbranko682-boop@users.noreply.github.com>
kumburovicbranko682-boop
requested review from
Map1en,
fffonion,
karrot0,
liksunrice and
mayocream
as code owners
June 27, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
When a Region is completely outside the image (e.g., self.x=100 on a 50-wide image), the clamp method incorrectly returns Some((49, y0, 1, h)) — a 1-pixel strip at the boundary — instead of None. This happens because x0 is capped at width-1 (49), then x1 is computed as max(..., x0)=50, yielding w=1. The caller has no way to know the region was entirely out-of-bounds and will silently crop a wrong sliver of the image.
Severity:
highFile:
koharu-app/src/utils.rsSolution
Add an early-exit check for fully out-of-bounds regions before the min/max calculations:
Changes
koharu-app/src/utils.rs(modified)Testing
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #825