Skip to content

fix: update color when picker drag ends outside the selection box#729

Open
MOULINIER wants to merge 2 commits into
mayocream:mainfrom
MOULINIER:fix/color-picker-corners-unregistered
Open

fix: update color when picker drag ends outside the selection box#729
MOULINIER wants to merge 2 commits into
mayocream:mainfrom
MOULINIER:fix/color-picker-corners-unregistered

Conversation

@MOULINIER

Copy link
Copy Markdown

(First commit to a major project, sorry if I made any mistakes on the PR)

Summary
When picking a color on the color picker box, it bugged me that when selecting colors at the corners like #FFFFFF or #000000 they weren't actually selected. It seems that when the cursor ends up outside of the box when selecting, the color isn't registered.

Changes

Tests and AI
I ran the integrated bun run --filter ui test.
Tested the fix manually.

I used AI to help me debug and learn the structure (I am a CS student and still learning!)

@github-actions

Copy link
Copy Markdown

Thanks for your first PR to Koharu.

Please review our contribution guide before review:
https://koharu.rs/contribute/introduction/

In the PR description, include:

  • what changed
  • any user-visible behavior differences
  • how you verified the change

If AI helped produce the patch, a human still needs to review and understand it before submission.

@MOULINIER MOULINIER changed the title fix: commit color when picker drag ends outside the selection box fix: update color when picker drag ends outside the selection box May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant