fix: update color when picker drag ends outside the selection box#729
Open
MOULINIER wants to merge 2 commits into
Open
fix: update color when picker drag ends outside the selection box#729MOULINIER wants to merge 2 commits into
MOULINIER wants to merge 2 commits into
Conversation
MOULINIER
requested review from
Map1en,
fffonion,
karrot0,
liksunrice and
mayocream
as code owners
May 26, 2026 14:57
|
Thanks for your first PR to Koharu. Please review our contribution guide before review: In the PR description, include:
If AI helped produce the patch, a human still needs to review and understand it before submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(First commit to a major project, sorry if I made any mistakes on the PR)
Summary
When picking a color on the color picker box, it bugged me that when selecting colors at the corners like #FFFFFF or #000000 they weren't actually selected. It seems that when the cursor ends up outside of the box when selecting, the color isn't registered.
Changes
Tests and AI
I ran the integrated bun run --filter ui test.
Tested the fix manually.
I used AI to help me debug and learn the structure (I am a CS student and still learning!)