Skip to content

Conversation

@maxisam
Copy link
Owner

@maxisam maxisam commented Sep 24, 2025

Change the artifact naming convention to utilize the run number instead of the reference name to avoid /

@maxisam maxisam merged commit 6f44a87 into master Sep 24, 2025
@chatgpt-codex-connector
Copy link

💡 Codex Review

run: |
# Use runner.arch which resolves to 'x64' or 'arm64'
FINAL_NAME="git-crypt-${{ github.run_number }}-darwin-${{ runner.arch }}"

[P1] Preserve release tag in macOS artifact names

Switching FINAL_NAME to github.run_number removes the release tag from the macOS asset name. On release runs, this now uploads files like git-crypt-123-darwin-x64, whereas the Linux and Windows workflows still produce tag-based assets (e.g. git-crypt-v1.4.0-…). Losing the tag makes the published binaries versionless and breaks tooling or scripts that expect the version in the filename. Consider using the run number only for non-release builds and retaining github.ref_name (the tag) for release builds.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@maxisam
Copy link
Owner Author

maxisam commented Sep 24, 2025

it works now. Thanks for the PR

https://github.com/maxisam/git-crypt/actions/runs/17981154013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants