Skip to content

Harden Chromium fetch, CI, and release flow#19

Merged
max4c merged 4 commits intomainfrom
codex/chromium-ci-hardening
Apr 8, 2026
Merged

Harden Chromium fetch, CI, and release flow#19
max4c merged 4 commits intomainfrom
codex/chromium-ci-hardening

Conversation

@max4c
Copy link
Copy Markdown
Owner

@max4c max4c commented Apr 8, 2026

Summary

  • add the pinned CEF fetch script and move vendor paths under macos/vendor/cef
  • update CI to cache and fetch CEF, regenerate the Xcode project, and build the Chromium macOS app target
  • switch the release script and README guidance onto the Xcode/CEF app build while keeping SwiftPM as the WebKit fallback path

Testing

  • swift build
  • swift test
  • bash scripts/smoke-cli.sh
  • bash scripts/fetch-cef.sh
  • cd macos && xcodegen generate
  • xcodebuild -project /Users/maxforsey/Code/bugbook-chromium-stack/macos/Bugbook.xcodeproj -scheme BugbookApp -configuration Debug build

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebc74775f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +24 to +25
if [ ! -d "$REPO_ROOT/macos/vendor/cef/current/Release/Chromium Embedded Framework.framework" ]; then
bash "$REPO_ROOT/scripts/fetch-cef.sh"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refresh CEF runtime unconditionally before release build

The release flow skips scripts/fetch-cef.sh whenever macos/vendor/cef/current/Release/Chromium Embedded Framework.framework already exists, but that only proves some runtime is present, not that it matches the pinned version or host architecture. If current points to an older pin (or to x64 artifacts from a prior Rosetta/x86 run), this script will silently build against stale/incompatible CEF and can fail link/run or ship the wrong runtime. Calling the fetch script every time (or validating current against expected platform/version) avoids that mismatch.

Useful? React with 👍 / 👎.

@max4c max4c changed the base branch from codex/chromium-macos-default to main April 8, 2026 17:41
@max4c max4c merged commit b7b3ca2 into main Apr 8, 2026
1 check passed
@max4c max4c deleted the codex/chromium-ci-hardening branch April 8, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant