Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebc74775f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ ! -d "$REPO_ROOT/macos/vendor/cef/current/Release/Chromium Embedded Framework.framework" ]; then | ||
| bash "$REPO_ROOT/scripts/fetch-cef.sh" |
There was a problem hiding this comment.
Refresh CEF runtime unconditionally before release build
The release flow skips scripts/fetch-cef.sh whenever macos/vendor/cef/current/Release/Chromium Embedded Framework.framework already exists, but that only proves some runtime is present, not that it matches the pinned version or host architecture. If current points to an older pin (or to x64 artifacts from a prior Rosetta/x86 run), this script will silently build against stale/incompatible CEF and can fail link/run or ship the wrong runtime. Calling the fetch script every time (or validating current against expected platform/version) avoids that mismatch.
Useful? React with 👍 / 👎.
Summary
macos/vendor/cefTesting