Refactor browser layer behind engine abstraction#17
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abc83cd020
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let configuration = WKWebViewConfiguration() | ||
| configuration.websiteDataStore = websiteDataStore | ||
| configuration.defaultWebpagePreferences.allowsContentJavaScript = true |
There was a problem hiding this comment.
Each call to makePage creates a new WKWebViewConfiguration but never assigns a shared processPool. This regresses the previous behavior where all tabs reused one pool, and in WebKit that can isolate session-scoped browsing state between tabs (for example, authentication/session cookies), so opening a site in a new tab may not inherit the logged-in state from an existing tab. Keep a single WKProcessPool on WebKitBrowserEngine and set configuration.processPool when creating each page.
Useful? React with 👍 / 👎.
1 participant
Summary
BrowserManager,BrowserPaneView, and browser save flow onto the engine interfaceTesting