Resolve Linux Warning & Improve Windows Debugging

[HTRamsey]

There were some unused return values with no discard
Also implements setWindowsNativeFunctions for some basic windows debugging functions
Includes #13306

[Copilot]

Pull Request Overview

This PR refactors platform-specific initialization code and improves cross-platform signal handling, particularly enhancing Windows debugging capabilities. The changes consolidate scattered platform setup code into a centralized Platform module and modernize signal handling with better Windows support.

• Centralizes platform-specific initialization into Platform::setupPreApp() and Platform::setupPostApp()
• Implements Windows signal handling using console control handlers alongside existing POSIX signal handling
• Removes unused return value warnings by adding explicit void casts

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/main.cc	Consolidates platform setup calls and removes scattered initialization code
src/Utilities/Platform.h	Adds new platform setup API with pre/post app initialization functions
src/Utilities/Platform.cc	Implements centralized platform setup including Windows error handling and debugging
src/Utilities/SignalHandler.h	Modernizes signal handler with Windows support and atomic operations
src/Utilities/SignalHandler.cc	Implements cross-platform signal handling with Windows console control handlers
src/Utilities/QGCLogging.h	Simplifies logging handler installation API
src/Utilities/QGCLogging.cc	Removes Windows-specific CRT report hook (moved to Platform)
src/Utilities/CMakeLists.txt	Updates build conditions to include SignalHandler on all desktop platforms
src/RunGuard.h	Adds copy constructor disabling for better safety
src/QGCApplication.h	Adds logging category declaration

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The WindowsInvalidParameterHandler function is empty, which may not provide meaningful error handling. Consider adding logging or appropriate error handling logic.

[Copilot]

The write operation in the signal handler could fail, but there's no way to report this error since logging isn't safe in signal handlers. Consider documenting this limitation or adding a fallback mechanism.

Suggested change

	[[maybe_unused]] const ssize_t n = ::write(self->_sigIntFd[1], &b, sizeof(b)); // no logging from signal handler
	// Only async-signal-safe functions allowed; cannot log here.
	// If write fails, the signal will not be delivered, so exit immediately as a fallback.
	const ssize_t n = ::write(self->_sigIntFd[1], &b, sizeof(b));
	if (n != sizeof(b)) {
	_exit(128 + SIGINT); // Fallback: exit with signal code
	}

[Copilot]

Similar to the SIGINT handler, the write operation could fail but cannot be reported. This is a limitation of signal-safe programming that should be documented.

Suggested change

	const char b = 1;
	const char b = 1;
	// Signal-safe programming limitation: the write operation below could fail,
	// but errors cannot be reported or handled safely in a signal handler.
	// This is an accepted limitation and should be documented.

[Copilot]

The buffer size (128) is hardcoded. Consider using a named constant or sizeof(buf) to make the code more maintainable and less error-prone.

Suggested change

	(void) _snwprintf_s(buf, _TRUNCATE, L"QGC: unhandled SEH 0x%08lX\n", static_cast<unsigned long>(code));
	(void) _snwprintf_s(buf, sizeof(buf)/sizeof(buf[0]), L"QGC: unhandled SEH 0x%08lX\n", static_cast<unsigned long>(code));