Skip to content

[Snyk] Upgrade react-dom from 18.3.1 to 19.2.0 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mauriciomenon wants to merge 1 commit into from
Closed

[Snyk] Upgrade react-dom from 18.3.1 to 19.2.0 #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go_wails_react/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"dependencies": {
"react": "^18.2.0",
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading react-dom to 19.2.0 while keeping react at 18.2.0 creates a version mismatch. React and react-dom must have matching major versions to work correctly. The react dependency should also be upgraded to ^19.2.0 to match react-dom.

Suggested change
"react": "^18.2.0",
"react": "^19.2.0",

Copilot uses AI. Check for mistakes.
"react-dom": "^18.2.0"
"react-dom": "^19.2.0"
Comment on lines 14 to +15
Copy link
Copy Markdown

@amazon-q-developer amazon-q-developer bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Version Mismatch: React and React DOM versions must be synchronized. Upgrading only react-dom to 19.2.0 while keeping react at 18.2.0 will cause runtime errors and compatibility issues.

Suggested change
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react-dom": "^19.2.0"
"react": "^19.2.0",
"react-dom": "^19.2.0"

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR upgrades react-dom to v19 but leaves react on v18. The react and react-dom packages must always be on the same major version to prevent runtime errors. Please upgrade react as well.

Important: React 19 introduces breaking changes. You should review the official React 19 upgrade guide.

Furthermore, this is a TypeScript project, but official type definitions for React 19 (@types/react and @types/react-dom) may not be stable yet. You may encounter type errors or have to use temporary solutions.

If you decide to proceed, your dependencies should be updated as follows:

  "dependencies": {
    "react": "^19.2.0",
    "react-dom": "^19.2.0"
  }

You will also need to find and update to compatible versions of @types/react, @types/react-dom, and other related libraries in devDependencies.

Copy link
Copy Markdown

@kilo-code-bot kilo-code-bot bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 CRITICAL: Version Mismatch

React and React DOM versions must be synchronized. This PR only upgrades react-dom to 19.2.0 while keeping react at 18.2.0, which will cause:

  • Runtime errors and crashes
  • Type compatibility issues
  • Hook behavior mismatches
  • Build failures

Required fix: Upgrade both packages together to the same major version:

Suggested change
"react-dom": "^19.2.0"
"react": "^19.2.0",
"react-dom": "^19.2.0"

This is a breaking change that requires both packages to be upgraded simultaneously.

Copy link
Copy Markdown

@llamapreview llamapreview bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 | Confidence: Medium

  • Speculative: The upgrade skips React 19.0.x and 19.1.x, jumping directly to 19.2.0. While this is the latest version, it's prudent to review the React 19.0.0 and 19.1.0 release notes for breaking changes specific to the codebase's usage patterns. The PR description includes extensive release notes; a focused review of breaking changes in the major version upgrade (18→19) is necessary beyond just updating the version number.
  • Speculative: This upgrade should be validated with comprehensive test runs. The related_context doesn't show test files, but the PR description notes React 19 changes to useId (colon to underscore) and Suspense batching. If tests rely on specific DOM IDs generated by useId or timing of Suspense boundary reveals, they may fail. Additionally, the upgrade should be tested with the actual Wails application to ensure the React integration with Go backend remains functional.

},
Comment on lines 13 to 16
Copy link
Copy Markdown

@llamapreview llamapreview bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 | Confidence: High

This upgrade creates a major version mismatch between react (v18) and react-dom (v19). React 19 introduces breaking changes and requires React peer dependency v19. The related_context shows both main.jsx and main.tsx import and use react-dom/client APIs (createRoot, ReactDOM.createRoot). Running with mismatched major versions will likely cause runtime errors, unexpected behavior, or build failures. This is a breaking change that requires coordinated upgrade of the react package to v19.

Suggested change
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react-dom": "^19.2.0"
},
"dependencies": {
"react": "^19.2.0",
"react-dom": "^19.2.0"
}

Evidence: path:go_wails_react/frontend/src/main.jsx, path:go_wails_react/frontend/src/main.tsx, symbol:createRoot, symbol:ReactDOM

"devDependencies": {
Copy link
Copy Markdown

@llamapreview llamapreview bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 | Confidence: High

The TypeScript type definitions remain at React 18 versions while the runtime dependency upgrades to React 19. This mismatch will cause type errors and incorrect type checking, as the @types/react and @types/react-dom packages for v18 don't include v19 API changes. The main.tsx file uses ReactDOM from react-dom/client, making accurate typing critical. This creates a compile-time breaking change.

Suggested change
"devDependencies": {
"devDependencies": {
"@types/react": "^19.2.0",
"@types/react-dom": "^19.2.0",
}

Evidence: path:go_wails_react/frontend/src/main.tsx, search:ReactDOM

P2 | Confidence: Medium

Speculative: The React testing library and Vite React plugin may have compatibility requirements with React 19. @testing-library/react v16 supports React 18, but React 19 compatibility should be verified. @vitejs/plugin-react v2 is likely compatible, but best practice is to check for recommended versions. Without updating these, tests and builds may fail or behave unexpectedly.

Code Suggestion:

Check compatibility and potentially update:
"devDependencies": {
  "@testing-library/react": "^16.3.0", // Verify v16 works with React 19
  "@vitejs/plugin-react": "^4.0.0", // v4+ officially supports React 19
}

Evidence: path:go_wails_react/frontend/src/main.jsx, path:go_wails_react/frontend/src/main.tsx

"@testing-library/jest-dom": "^6.9.1",
Expand Down