Skip to content

Title fix: add missing rxjs peer dependency #1790

Open
Emtiaz01 wants to merge 1 commit intomattlewis92:mainfrom
Emtiaz01:fix/add-rxjs-peer-dep
Open

Title fix: add missing rxjs peer dependency #1790
Emtiaz01 wants to merge 1 commit intomattlewis92:mainfrom
Emtiaz01:fix/add-rxjs-peer-dep

Conversation

@Emtiaz01
Copy link

@Emtiaz01 Emtiaz01 commented Nov 15, 2025

fix: add missing rxjs peer dependency #1789

Summary
This PR adds rxjs to the library’s peerDependencies to properly declare it as a required runtime dependency.
The library imports and uses RxJS internally, but it was not listed in dependencies or peerDependencies, which can lead to build errors in consumer applications.

What was changed
Added "rxjs": "^7.6.0" to peerDependencies in package.json.
This version aligns with the RxJS version already used in the library’s development environment (devDependencies).

Why this change is needed
Angular libraries are expected to define RxJS as a peer dependency because:
The library uses RxJS at runtime.
TypeScript needs to resolve RxJS types during compilation.
Consumer applications must supply a compatible RxJS version.
Missing peer/dependencies violate npm package rules and may cause:
build-time errors
type resolution failures
dependency mismatch issues

How this fixes the original issue
Declaring RxJS as a peer dependency ensures:
consumers are required to install RxJS
Angular and RxJS versions stay consistent across the application
bundlers do not incorrectly include additional copies of RxJS
compilation and runtime errors related to missing RxJS are resolved

Testing
Successfully built the library after the change
Verified that TypeScript no longer reports missing RxJS when consuming the library
Confirmed that no behavior is changed — this update only corrects dependency metadata

@Emtiaz01
Copy link
Author

Emtiaz01 commented Nov 15, 2025

Hi!
This PR adds the missing rxjs peer dependency to fix the unmet dependency issue.

It looks like the workflows and tests are waiting for maintainer approval.
Could someone please review and approve the workflow so the checks can run?

Thank you!

@Emtiaz01 Emtiaz01 changed the title Title fix: add missing rxjs peer dependency Title fix: add missing rxjs peer dependency #1789 Nov 15, 2025
@Emtiaz01 Emtiaz01 changed the title Title fix: add missing rxjs peer dependency #1789 Title fix: add missing rxjs peer dependency Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant