Skip to content

Sfdx scanner comments - Remove comments demo #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattisdada wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sfdx scanner comments - Remove comments demo #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c46f568
Use check-runs
mattisdada Mar 22, 2023
f9f9d87
Use comments
mattisdada Mar 22, 2023
d4f9e98
Remove one lint issue
mattisdada Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,10 @@ jobs:
npm install sfdx-cli
npx sfdx plugins:install @salesforce/sfdx-scanner
- name: SFDX Scanner
uses: mattisdada/sfdx-scan-pull-request@main
uses: mattisdada/sfdx-scan-pull-request@ts-port
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
report-mode: comments
delete-resolved-comments: true

4 changes: 3 additions & 1 deletion src/tests/SimpleRoute.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { AfterMiddleware, BeforeMiddleware, HttpCodes, HttpRequest, HttpResponse, Router } from "../SimpleRouter";
import { AfterMiddleware, BeforeMiddleware, HttpCodes, Router } from "../SimpleRouter";
import { HttpRequest } from "../HttpRequest";
Comment on lines +1 to +2
Copy link

@github-actions github-actions bot Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engine Category Rule Severity Type Message File
eslint-typescript problem @typescript-eslint/no-unused-vars 1 Warning 'HttpCodes' is defined but never used. src/tests/SimpleRoute.test.ts

Copy link
Owner Author

@mattisdada mattisdada Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should stay put

Copy link
Owner Author

@mattisdada mattisdada Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other comment has been removed as expected, this comment has stayed as-is

import { HttpResponse } from "../HttpResponse";

test("create middleware", async () => {
//const router = new Router();
Expand Down